[
https://issues.apache.org/jira/browse/OFBIZ-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677659#action_12677659
]
Ashish Vijaywargiya commented on OFBIZ-2205:
--------------------------------------------
Hello Abhinav,
Thanks for your great work on HR Recruitment Process.
I appreciate your efforts.
Here are some of my thoughts on your patch :
1) This is very big patch and takes good amount of time to review. Can you
please upload the short patch from next time ? It will help me or others to
review patch easily.
2) Please arrange the UiLabels for Recruitment in Alphabetical order.
3) We should rework on the HumanResRecruitmentData.xml file.
Here we should find out which data can be put in "seed" and which data can be
put in "demo".
If you need reference of data types you can read the build.xml file in ofbiz
home.
4) Can you please elaborate the purpose of LoginHR.groovy file ?
5) For service implementation (inside HumanResServices.xml)
5a) We should prefer to use <fail-property> tag instead of <fail-message> so
that we could internationalize the message.
5b) <check-permission> should be done in service definition. Please take a look
at "example" component for reference.
6) We should move the "CommonRecruitmentDecorator" into CommonScreens.xml file
and will use "location" attribute in each screen definition then call this
decorator by "${parameters.mainDecoratorLocation}".
We should also remove the entries of <property-map> from
"CommonRecruitmentDecorator".
7) Which document or book you have referred to create this recruitment process
? I will be more then happy to read and explore that :) in my spare time.
Thanks !
--
Ashish Vijaywargiya
> Implemented recruitment in HR module
> ------------------------------------
>
> Key: OFBIZ-2205
> URL: https://issues.apache.org/jira/browse/OFBIZ-2205
> Project: OFBiz
> Issue Type: New Feature
> Components: humanres
> Affects Versions: SVN trunk
> Environment: Windows XP Professional (5.1, Build 2600) Service Pack
> 2, Intel(R) Core(TM)2 CPU 4300 @ 1.80GHz (2 CPUs), 1014MB RAM, jdk1.5.0,
> apache-ant-1.7.0
> Reporter: Abhinav Vaid
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: HR_Recruitment.patch
>
>
> In this patch we have included recruitment in the HR module.
> Recruitment performs tasks such as admin can create new job requisitions.
> He can update or delete new job requisitions.
> Now once the job requisition has been added, it is visible to all the
> employees.
> Then if interested employee wants to apply for the job requisition he sends
> it for approval to his superior.
> Superior from his login can check who all have applied for job requisition.
> He can update the status and same is reflected at employee's end.
> Here admin can also create new interview types and he can store the
> information of the diffrent interviews of employees.
> We have created Security groups:
> HUMANRES_APPROVER
> HUMANRES_EMPLOYEE
> We have created Security permissions:
> HUMANRES_APPROVE
> We have created Login Id's :
> demoadmin belongs to FULLADMIN security group
> demoapprover belongs to HUMANRES_APPROVER security group
> demoemployee belongs to HUMANRES_EMPLOYEE security group
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
