[
https://issues.apache.org/jira/browse/OFBIZ-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680128#action_12680128
]
Ashish Vijaywargiya commented on OFBIZ-2205:
--------------------------------------------
Hello Abhinav,
Thanks for improving the patch.
Here are few more comments to improve the patch:
1) Please look at the console while clicking each link. It is giving error for
missing requirement for the tags in Xml files.
The reason is that some of the attribute has been deprecated and replaced by
new one.
For example :
<set-nonpk-fields map-name="parameters" value-name="newEntity"/>
Changed to
<set-nonpk-fields map-name="parameters" value-field="newEntity"/>
Change in value-name --> value-field.
Please update it in all the XML files. Also check the other tags and use the
proper attribute so we don't see console errors.
You can always take "Example" component for improving your files. As all these
changes are being done in "example" component first.
2) We should always put the seed data in XML files instead of hard coding all
the values in the form widget or FTL files.
For Example :
+ <option key="B.tech" description="B.tech"/>
+ <option key="MBA" description="MBA"/>
+ <option key="Bsc" description="Bsc"/>
+ <option key="Msc" description="Msc"/>
What should be the case if we will be having 50 degree course for selection
criteria ?
Please shift all this values in the seed data files.
3) Why are you using <auto-field-entity> twice in a patch, please explain ?
+ <auto-fields-entity entity-name="JobRequisition"
default-field-type="display"/>
+ <actions>
+ <set field="jobRequisitionId"
from-field="parameters.jobRequisitionId"/>
+ </actions>
+ <auto-fields-entity entity-name="JobRequisition"
default-field-type="find"/>
4) We should improve the naming convention.
Like for search form in "example" component we have used "FindExamples" &
"ListExamples".
"EditExample" screen definition is used for Create and Update operation on
single record of example.
"EditExampleFeatureAppls" screen definition is used to contain two forms. One
is list for and another is add form. (Note the use of "s" in the last of name)
5) Create the new Uilabel map entry for the following line or use use the
existing one if it presents.
<label>You Dont Have Permissions to Update</label>
Please review the code in example component before uploading another patch as
there might be so many places for improvement.
I will wait for your next updated patch.
--
Ashish Vijaywargiya
> Implemented recruitment in HR module
> ------------------------------------
>
> Key: OFBIZ-2205
> URL: https://issues.apache.org/jira/browse/OFBIZ-2205
> Project: OFBiz
> Issue Type: New Feature
> Components: humanres
> Affects Versions: SVN trunk
> Environment: Windows XP Professional (5.1, Build 2600) Service Pack
> 2, Intel(R) Core(TM)2 CPU 4300 @ 1.80GHz (2 CPUs), 1014MB RAM, jdk1.5.0,
> apache-ant-1.7.0
> Reporter: Abhinav Vaid
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: HR_Recruitment.patch, HR_Recruitment.patch
>
>
> In this patch we have included recruitment in the HR module.
> Recruitment performs tasks such as admin can create new job requisitions.
> He can update or delete new job requisitions.
> Now once the job requisition has been added, it is visible to all the
> employees.
> Then if interested employee wants to apply for the job requisition he sends
> it for approval to his superior.
> Superior from his login can check who all have applied for job requisition.
> He can update the status and same is reflected at employee's end.
> Here admin can also create new interview types and he can store the
> information of the diffrent interviews of employees.
> We have created Security groups:
> HUMANRES_APPROVER
> HUMANRES_EMPLOYEE
> We have created Security permissions:
> HUMANRES_APPROVE
> We have created Login Id's :
> demoadmin belongs to FULLADMIN security group
> demoapprover belongs to HUMANRES_APPROVER security group
> demoemployee belongs to HUMANRES_EMPLOYEE security group
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
