[
https://issues.apache.org/jira/browse/OFBIZ-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682753#action_12682753
]
David E. Jones commented on OFBIZ-2243:
---------------------------------------
Adrian: you're right that this could be smarter, and I thought about that when
writing it (at least choosing the hidden-form versus anchor link-type)... but
didn't really like the option of parsing the URL string for the parameters at
run-time (it's too messy and potentially error prone, IMO).
Maybe a good solution to this is to do the fancy search/replace that Jacques
has introduced, but ONLY for the parameters (which is the harder and more
laborious part) and not for the link-type attribute. That would be a nice
cleanup anyway over having the parameters embedded in the URL.
BTW, one caveat: it's not used very much, but in some cases the param-name does
not match the from-field, which is what it assumes if there is no from-field or
value. For example in the URL string we could have
"productId=${curProd.productId}". If you could watch for that and just leave
those out of the S/R that would be a good start for now.
Could you do that Jacques?
I'll add a new option to link-type, called "default" which will look at the
request corresponding to the link target and choose anchor or hidden-form
accordingly.
> In hyperlink element, replacement of target parameters by
> link-type="hidden-form" and parameter sub-elements
> ------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2243
> URL: https://issues.apache.org/jira/browse/OFBIZ-2243
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Jacques Le Roux
> Attachments: OFBIZ-2243.patch
>
>
> This issue is intended to replace, in all hyperlink elements used in forms,
> screens and menus widgets, target parameters by
> * link-type="hidden-form"
> * and parameter sub-elements
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
