[ 
https://issues.apache.org/jira/browse/OFBIZ-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683397#action_12683397
 ] 

Vikas Mayur commented on OFBIZ-2224:
------------------------------------

Pratik, 

Their are still conflicts in few files. I would appreciate if you can upload a 
new patch.

Apart from this few comments,

1) {code} <entity-condition entity-name="OrderItemAndShipGrpInvResAndItem" 
list="oisgirais">
                    <condition-list combine="and">
                        <condition-expr field-name="orderId" operator="equals" 
from-field="parameters.orderId"/>
                    </condition-list>
                </entity-condition>
     {code}
    since their is only one expression, this can be removed {code} 
<condition-list combine="and">{code}

2) Please also describe about (probably in the service description) what does 
high and low priorities means? I think order with high priority would be served 
first.

3) If possible, please add description about this field {code}<field 
name="priority" type="indicator"></field> {code}. Use 
<description></description> element.


> Setting priority of orders on inventory allocation so that other orders are 
> fulfilled while waiting for sufficient inventory to fill the large sales order
> ----------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2224
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2224
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order, product
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Vikas Mayur
>             Fix For: SVN trunk
>
>         Attachments: ofbiz-2224.patch, ofbiz-2224.patch
>
>
> While waiting for the inventory to arrive, user lowers priority on inventory 
> allocation so that other orders can be fulfilled while waiting for sufficient 
> inventory to fill the large sales order.
> *Implementation Notes:*
> * Re-do inventory reservations sorted by lower priority for these larger 
> orders.
> * Current code sorts reservations by currentPromisedDate, then 
> reservedDatetime, then sequenceId (re-reserves if enabled by the 
> ProductStore.balanceResOnOrderCreation field)
> * Add UI and supporting code to allow user to specify an order is a higher or 
> lower priority and inventory reservation should be done before or after all 
> other orders.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to