I was ready to change/refactor this page, notably, in the 1st section, I will
suggest to use Anyedit plugin in Eclipse for trailing
spaces.
But I'd like to make a proposition before. Like Adrian
(http://markmail.org/thread/sesxygbc6kj5r2yc) I really prefer to use 2 spaces
indentation in FTL, could we change our conventions to use 2 spaces in
FTL/HTML files ?
Also I'd like to know if we should use 2 spaces for XML. There are plenty of files where 2 spaces is used (notably in *model*.xml
files) and I found this often annoying when dealing whith those files (parching, merging, commiting changes, etc.).
IMO, 4 space should be olny used in java files and groovy, and 2 spaces everywhere else (but I may miss some types of files to be
put in the 4 spaces group, if you see one please react)
Jacques
From: "Jacques Le Roux" <[email protected]>
Yes, good point. I will wait to see Adam's progress... If nobody see a problem
with the changes he proposed (seems OK nobody
growled)
Jacques
From: "Stephen Rufle" <[email protected]>
If this the removal of trailing spaces is done, would it be good to also
update your comment on
http://docs.ofbiz.org/display/OFBADMIN/Coding+Conventions
Change the AnyEdit plug in section to have "Remove trailing whitespace"
to true
Jacques Le Roux wrote:
I did something like that sometimes ago, but only to transform tabs
into spaces. I'm not against cleaning this aspect of the code. We
could do it now, I mean before freezing 9.3, since there has been
already a lot of changes recently
So +1
Jacques
From: "BJ Freeman" <[email protected]>
sorry missed that part
Adam Heath sent the following on 3/13/2009 11:19 AM:
BJ Freeman wrote:
My thought was the it could be run before patches were made.
Sure, but we have tons of existing code that isn't compliant, that
needs to be fixed. I was asking whether I should do that now, or wait
for a bit for others to speak up.
--
Stephen P Rufle
[email protected]
H1:480-626-8022
H2:480-802-7173
Yahoo IM: stephen_rufle
AOL IM: stephen1rufle
