[
https://issues.apache.org/jira/browse/OFBIZ-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688809#action_12688809
]
David E. Jones commented on OFBIZ-2252:
---------------------------------------
This looks good in general Deepesh, and thanks for looking at all of the links
on that page.
Some opportunities for improvement:
1. keep things simple: instead of calling a JS method to submit the form just
use a URL like "javascript:document.${formName}.submit()"
2. avoid reformatting the file and keep your changes localized (ie in small
sets) so the patch is clean and it is easy to see what you have changed and
what you haven't; when you're a committer feel free to do more reformatting,
but for now this only delays reviews as it requires a lot more work from
committers who review it; for example these lines don't seem to have any
changes other than formatting:
- <div class="screenlet-title-bar">
- <ul>
- <#if orderHeader.externalId?has_content>
- <#assign externalOrder = "(" + orderHeader.externalId + ")"/>
- </#if>
- <#assign orderType = orderHeader.getRelatedOne("OrderType")/>
3. it was good that you followed up on the user mailing list, but a link to the
issue would have been easier to follow than a link to the patch
Thanks again! Looking forward to updates...
> Exception occurs while changing the order status
> ------------------------------------------------
>
> Key: OFBIZ-2252
> URL: https://issues.apache.org/jira/browse/OFBIZ-2252
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Deepesh Kapoor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2252.patch
>
>
> When the Status of the Order is changed then as parameters are passed as url
> parameters on the secured port, Exception
> org.ofbiz.webapp.event.EventHandlerException: Found URL parameter [orderId]
> passed to secure (https) request-map with uri [changeOrderStatus] occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
