[
https://issues.apache.org/jira/browse/OFBIZ-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-2178:
-----------------------------------
Attachment: promos_set up_shipping_sub_total_condition.patch
Hi Mukesh,
I had a deeper look, here are my remarks, see attached patch for details
* I prefer to speak about Shipping total than sub_total
* I have used a BigDecimal in ProductPromoWorker.java instead of a Double
* there is an issue when you modify an order (adding an item or modifying one)
: you loose the shipping total promotion. I guess it's because getShipEstimate
is not called again but it's more a bet than anything else and I do not have
enough time to look closer at it right now, help appreciated...
> Create the promotion on the basis of shipping total condition.
> --------------------------------------------------------------
>
> Key: OFBIZ-2178
> URL: https://issues.apache.org/jira/browse/OFBIZ-2178
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Reporter: Mukesh Manohar Marathe
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: promos_set up_shipping_sub_total_condition.patch,
> promos_set up_shipping_sub_total_condition.patch
>
>
> We can not create the promotion on the basis of shipping total condition. We
> can add the new condition which will create the promotion on shipping total.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
