[
https://issues.apache.org/jira/browse/OFBIZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695369#action_12695369
]
Vikas Mayur commented on OFBIZ-2226:
------------------------------------
Hi Akash, Patch looks good. Just few changes, I would suggest.
1)
{code}
+ BigDecimal qtyToVerify = BigDecimal.ZERO;
+ BigDecimal qtyToVerified = BigDecimal.ZERO;
+ BigDecimal verifiedQuantity = BigDecimal.ZERO;
+ BigDecimal readyToVerifyQty = BigDecimal.ZERO; {code}
Define this on top of the file and use it. Something like
{code} private static BigDecimal ZERO = BigDecimal.ZERO; {code}
2) NPE can occur at
{code}
+ if ((orderItem.getString("productId")).equals(productId)) {
{code}
instead use
{code} + if (productId.equals(orderItem.getString("productId")))
{{code}
3) Try to use entity names so this
{code} + bin = delegator.findOne("PicklistBin", [picklistBinId :
picklistBinId], false); {code}
could be
{code}+ pickListBin = delegator.findOne("PicklistBin", [picklistBinId :
picklistBinId], false); {code}
4) Use the secure method for
{code}
+ <menu-item name="VerifyPick" title="Verify Pick">
+ <link target="VerifyPick?facilityId=${facilityId}"/>
+ </menu-item>
{code}
Please see recent commits on how this can be done.
Vikas
> Create new screen with Facility Tab: "Verify Pick" to allow user to verify a
> pick.
> ----------------------------------------------------------------------------------
>
> Key: OFBIZ-2226
> URL: https://issues.apache.org/jira/browse/OFBIZ-2226
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2226.patch, OFBIZ-2226.patch
>
>
> Create new screen with a Facility Tab: "Verify Pick"
> # To be based on the existing Facility -> Packing screens
> # Initial screen the same as for the Facility -> Packing tab, ie a form with
> orderId and shipGroupSeqId, or with a picklist bin ID.
> # If the item match, then user will click on complete button and status of
> shipment will be set to picked, then automatically invoice should be created
> in "INVOICE_IN_PROCESS" status. We can give Link for invoice after shipment
> status for any particular order is set to "Picked".
> # If user clicks on the "Cancel" button, system cancels any saved data,
> clears out session data, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
