[
https://issues.apache.org/jira/browse/OFBIZ-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695874#action_12695874
]
Vikas Mayur commented on OFBIZ-2223:
------------------------------------
Hi Arun, Patch looks good. Few changes that I would suggest (and would like you
to test with those changes :)) are
1) I think this can be replaced (or probably similar occurrence)
{code}
<!-- adds location of item in location list uniquely -->
<if-compare field="groupByWarehouseArea" operator="equals"
value="Y">
<set field="addInList" value="Y"/>
<if-not-empty field="locations">
<iterate list="locations" entry="location">
<if-compare-field field="location"
operator="equals" to-field="locationGroupName">
<set field="addInList" value="N"/>
</if-compare-field>
</iterate>
</if-not-empty>
<if-compare field="addInList" operator="equals"
value="Y">
<field-to-list field="locationGroupName"
list="locations"/>
</if-compare>
<clear-field field="addInList"/>
</if-compare>
{code}
with
{code}
<!-- adds location of item in location list uniquely -->
<if-compare field="groupByWarehouseArea" operator="equals"
value="Y">
<if>
<condition><not><if-compare-field field="locations"
operator="contains" to-field="locationGroupName"/></not></condition>
<then><field-to-list field="locationGroupName"
list="locations"/></then>
</if>
</if-compare>
{code}
2) Try to use from-field instead of value in following case.
{code}
<if-compare field="groupByWarehouseArea" operator="equals"
value="Y">
<set field="groupName2"
value="${OrderItemAndFacilityLocation.areaId}"/>
<set field="locationGroupName"
value="${OrderItemAndFacilityLocation.areaId}"/>
</if-compare>
{code}
I think #1 would result in less number of code and would increase the clarity
of the code as well.
Thanks,
Vikas
> User can select options for preparing a group on the basis of Shipping
> method, Warehouse area and Number of order items (one to two, three or more).
> So that group of Orders are created according to selected options.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2223
> URL: https://issues.apache.org/jira/browse/OFBIZ-2223
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2223.patch
>
>
> When order is ready to pick (ie in approved status), User go to
> Facility-->Picking, then group is already prepared on the basis of shipping
> method (for creating picklist) . We should have functionality where User can
> select options for preparing a group on the basis of Shipping method,
> Warehouse area and Number of order items (one to two, three or more). So that
> group of Orders are created according to the selected options. Pick list
> create functionality will be working as it is.
> *Implementations Notes:*
> * Go to Facility -> Picking tab or page
> https://localhost:8443/facility/control/PicklistOptions?facilityId=WebStoreWarehouse
> * Select factors to group by, using one checkbox for each:
> *# Number of order items (one to two, three or more).
> *# Warehouse area.
> *# Shipping method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
