[ 
https://issues.apache.org/jira/browse/OFBIZ-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya updated OFBIZ-2271:
---------------------------------------

    Attachment: New_Ant_Targets.patch

Few comments :

1) We should avoid the unnecessary lines in the patch. (See unnecessary + & - 
in the patch)
-
+        
     <!-- ================================================================== -->
     <!-- Initialization of all property settings                            -->
     <!-- ================================================================== -->
-
+    
     <property environment="env"/>
     <property name="desc" value="@component-resource-name@ Component"/>
     <property name="name" value="ofb...@component-name@"/>
@@ -15,7 +15,7 @@
     <property name="dtd.dir" value="dtd"/>
     <property name="lib.dir" value="lib"/>
     <property name="build.dir" value="build"/>
-
+        
     <path id="local.class.path">
         <fileset dir="${lib.dir}" includes="*.jar"/>
         <fileset dir="../../framework/base/lib" includes="*.jar"/>
@@ -31,19 +31,19 @@
         <fileset dir="../../framework/webapp/lib" includes="*.jar"/>
         <fileset dir="../../framework/webapp/build/lib" includes="*.jar"/>
     </path>
-
+        
     <!-- ================================================================== -->
     <!-- Compilation of the source files                                       
                                                                                
  -->
     <!-- ================================================================== -->
-
+    
     <target name="classes" depends="prepare">
         <javac15/>
     </target>
-
+    
     <!-- ================================================================== -->
     <!-- Build JavaDoc                                                      -->
     <!-- ================================================================== -->
-
+    

2) Providing the option to use "component-name" property that has been setup in 
the top of build.xml file instead of passing it from command line.
(using -Dcomponent-name="name of component")

-    <property name="name" value="ofb...@component-name@"/>
+    <property name="component-name" value="ofb...@component-name@"/>


3) We should avoid following details from the patch.
### Eclipse Workspace Patch 1.0
#P ofbiztest

Either create patch from the terminal or Select second option "Project" instead 
of "Workspace".
You can see the "Workspace" option selected by default when you will click on 
the "Next" button while creating patch from eclipse.

--
Ashish Vijaywargiya

> New targets for custom component's build.xml file
> -------------------------------------------------
>
>                 Key: OFBIZ-2271
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2271
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Ashish Vijaywargiya
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>         Attachments: New_Ant_Targets.patch, New_Ant_Targets.patch, 
> New_Ant_Targets.patch
>
>
> There is now an ant target to automatically generate the layout of an 
> hot-deploy component.(i.e ant create-component)
> It would be nice to add, to the generated build.xml file in the hot-deploy 
> component, ant targets to create/apply/revert patches for the framework, 
> applications and specialpurpose.
> The idea is to automate the process of creating patches (and storing them in 
> the patches folder of the custom component), applying them and reverting.
> The workflow could be the following one:
> 1) A developer creates a custom hot deploy component for a customer using the 
> proper ant target. 
> 2) The developer modifies the code (e.g. config files etc...) in framework, 
> applications and specialpurpose, then run the "create-patch" target 
> that will create a patch and store it in the patches folder.
> 3) Every time the component is built, we could revert the mods and reapply 
> all the patches.
> --
> Ashish Vijaywargiya

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to