Re: [jira] Commented: (OFBIZ-2260) Secure URLs in Freemarker templates files

[Ashish Nagar]

Hello Stephen,

Would <a> outside the form, make any difference? As we are just calling 
a js function with the link. The link within the form will make <a> as a 
part of the form, so will be helpful to make the "link" layout fit 
inside the form. Clearing the browser cache might help here.

Thanks & Regards,
--
Ashish Nagar

Stephen Rufle wrote:
I think the <a> needs to be outside the form.

CJ Horton (JIRA) wrote:
  
    [ https://issues.apache.org/jira/browse/OFBIZ-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696733#action_12696733 ] 

CJ Horton commented on OFBIZ-2260:
----------------------------------

Here is another one as of Rev. 762387

Page: https://localhost:8443/accounting/control/EditCustomTimePeriod
Link: 
https://localhost:8443/accounting/control/deleteCustomTimePeriod?customTimePeriodId=6001&currentCustomTimePeriodId=&findOrganizationPartyId=
Link: 
https://localhost:8443/accounting/control/deleteCustomTimePeriod?customTimePeriodId=6001

I tried to make a patch for this, but am having an "issue" with the javascript. 

If I code like the following the Delete link does nothing when clicked:

<form name="DeleteCustomTimePeriod" method="post" 
action="<@ofbizUrl>deleteCustomTimePeriod</@ofbizUrl>">
<input type="hidden" name="customTimePeriodId" 
value="${customTimePeriod.customTimePeriodId?if_exists}">
<input type="hidden" name="currentCustomTimePeriodId" 
value="${currentCustomTimePeriodId?if_exists}">
<input type="hidden" name="findOrganizationPartyId" 
value="${findOrganizationPartyId?if_exists}">
<a href="javascript:document.DeleteCustomTimePeriod.submit()" 
>${uiLabelMap.CommonDelete}</a>
</form>

But, coding it like this works:

<form name="DeleteCustomTimePeriod" method="post" 
action="<@ofbizUrl>deleteCustomTimePeriod</@ofbizUrl>">
<input type="hidden" name="customTimePeriodId" 
value="${customTimePeriod.customTimePeriodId?if_exists}">
<input type="hidden" name="currentCustomTimePeriodId" 
value="${currentCustomTimePeriodId?if_exists}">
<input type="hidden" name="findOrganizationPartyId" 
value="${findOrganizationPartyId?if_exists}">
<input type="submit" value='${uiLabelMap.CommonDelete}'>
</form>

Am I missing  something here?  Advice is greatly appreciated!!


  
    
Secure URLs in Freemarker templates files
-----------------------------------------

                Key: OFBIZ-2260
                URL: https://issues.apache.org/jira/browse/OFBIZ-2260
            Project: OFBiz
         Issue Type: Improvement
         Components: ALL COMPONENTS
   Affects Versions: Release Branch 4.0, Release Branch 9.3
           Reporter: Jacques Le Roux
           Assignee: Jacques Le Roux
            Fix For: Release Branch 4.0, Release Branch 9.3

        Attachments: listPortalPortlets.patch, OFBIZ-2256.patch, 
OFBIZ-2260.patch, OFBIZ-2260.patch, orderitems.patch, UpdateLabelsFiles.patch


Follow OFBIZ-2256 but for FTL files only