[email protected] wrote: > Author: jonesde > Date: Fri Apr 17 18:26:37 2009 > New Revision: 766112 > > URL: http://svn.apache.org/viewvc?rev=766112&view=rev > Log: > Added the Linux/Unix version of the mergefromtrunk script > > Added: > ofbiz/branches/release09.04/mergefromtrunk.sh (with props) > > Added: ofbiz/branches/release09.04/mergefromtrunk.sh > URL: > http://svn.apache.org/viewvc/ofbiz/branches/release09.04/mergefromtrunk.sh?rev=766112&view=auto > ============================================================================== > --- ofbiz/branches/release09.04/mergefromtrunk.sh (added) > +++ ofbiz/branches/release09.04/mergefromtrunk.sh Fri Apr 17 18:26:37 2009 > @@ -0,0 +1,6 @@ > +#!/bin/sh > + > +prevRev=`expr $1 - 1` > +svn merge -r $prevRev:$1 https://svn.apache.org/repos/asf/ofbiz/trunk > +svn commit -m "Applied fix from trunk for revision: $1" > +
Bother. prevRev=$(($1 - 1)). $(()) is posix. Additionally, what happens if someone doesn't specify $1 when the script is called? There's no set -e, no safe shell programming techniques. I'll fix this myself; shell programming issues are a pet peeve of mine. Also, where is the license header?
