[
https://issues.apache.org/jira/browse/OFBIZ-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701087#action_12701087
]
David E. Jones commented on OFBIZ-2288:
---------------------------------------
With source repositories you either use them right, or they are useless... and
a real pain on top of useless. The first rule is to always work in your
sandbox... always. That means work on the files right in the directory you
checked out. It's easy to kill other people's changes if you copy a file into a
checkout directory that is based on a different checkout revision than the one
you copy it into.
Keep in mind that SVN (or whatever) keeps track of the differences between your
file and the version you checked out. That way when you update it knows which
lines you changed and can merge them with lines others changed. If you lose the
link between the file you're editing and the source repo revision it is based
on, problems happen.
A couple of common scenarios that will cause problems:
1. checkout in directory A, edit a file; checkout in directory B with a
different revision (usually a later checkout); copy file from A to B and when
you do a diff in B it will undo all changes in the repository between the
revisions for A and B
2. checkout in directory A; copy a file into directory X and edit it there;
update the sandbox/checkout in directory A; copy the file back from directory X
to directory A; SVN will think the file is based on the latest revision, just
it is based on the earlier revision... and that will cause it to undo all the
changes
In general: please read through the patch file your produce and check each
line! Remember that when you submit a patch you are asking the committer who
volunteers to review every line of the patch (that's what they _should_ be
doing anyway).
=====================
Back to the main point of the new patch (indexUpdate.patch): the file is 1749
lines long, with lots of changes that don't seem to have anything to do with
the changes described, and that means it takes a LONG time to review it and
significantly increases the chance of problems with the patch.
There are a couple of files added by it that I'm not sure about the purpose of,
namely full.html, subpage.html, and style.html.
There are lots of lines changed that appear to have no change other than
formatting, but it's hard to tell by reviewing them manually. Please avoid
formatting changes, this helps to make patches a LOT smaller and makes things
way easier to review.
There are still changes in the index.html file that appear to move things
around to different parts of the file that were changed in recent revisions,
which is specifically what leads me to believe that this file got mixed up with
the wrong revision.
> Update the image / content scroller on index.html
> -------------------------------------------------
>
> Key: OFBIZ-2288
> URL: https://issues.apache.org/jira/browse/OFBIZ-2288
> Project: OFBiz
> Issue Type: Improvement
> Components: site
> Affects Versions: SVN trunk
> Reporter: Tim Ruppert
> Assignee: Tim Ruppert
> Fix For: SVN trunk
>
> Attachments: Archive.zip, images.zip, index.patch, indexUpdate.patch,
> ofbizSiteTemplate.zip
>
>
> Currently there is a JavaScript scroller on the index.html page, but it's not
> clear to everyone that it is there. Let's do this:
> 1. Make it so that they scroll ever 10 seconds between what is there.
> 2. Put a pause on it - which will stop the scrolling, but allow you to start
> it up again.
> 3. Make it so what comes up first is totally random
> 4. Make it so it scrolls around to the beginning again instead of stopping at
> the last one (in either direction)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
