[ 
https://issues.apache.org/jira/browse/OFBIZ-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710266#action_12710266
 ] 

Ryan Foster commented on OFBIZ-2469:
------------------------------------

Shi,

If you are gong to modify widths on the 4 input fields referenced above (or any 
input fields for that matter)...

1. Don't use the "size" attribute as in " <input 
type="text"name="SEARCH_STRING" size="20""...
2. Don't use an inline style width either, as in "style="width:173px;"...

Having an inline size and width is redundant, and "size" will render 
differently in different browsers.  You are much better off assigning the input 
field a class name and then setting the width in an external style sheet.  That 
way, you can adjust the width on a per browser basis if you need to.  Using an 
inline style on the examples above makes it impossible to adjust the width 
using of those fields using CSS, because an inline style will always trump an 
ID or Class name.  


> CSS fixes for Linux + Firefox 3
> -------------------------------
>
>                 Key: OFBIZ-2469
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2469
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04
>         Environment: OFBiz 9.0.4 + Fedora 10 + Firefox 3 + Chinese Language + 
> OpenJDK 1.6.0
>            Reporter: Shi Yusen
>            Priority: Trivial
>         Attachments: catalog09.04-Fedora10-FF3.png, 
> ecommerce09.04-Fedora10-FF3.png, OFBIZ-2469-20090513.patch
>
>
> 1. themes/smoothfeather/webapp/smoothfeather/css/forms.css
> add "white-space: nowrap;" to 
> .label {
>       margin:0;
>       padding:0;
>       font-size:11px;
>       line-height:10px;
> }
> URL to see the improvement: 
> /myportal/control/showPortalPage?portalPageId=MYPORTAL_EMPLOYEE1&parentPortalPageId=MYPORTAL_EMPLOYEE
> 2. applications/product/webapp/catalog/find/keywordsearchbox.ftl
> Change 
> <span class="label">${uiLabelMap.ProductKeywords}:</span><input 
> type="text"name="SEARCH_STRING" size="20" maxlength="50" 
> value="${requestParameters.SEARCH_STRING?if_exists}"/>
> to
> <span class="label">${uiLabelMap.ProductKeywords}:</span><input 
> type="text"name="SEARCH_STRING" size="20" maxlength="50" 
> value="${requestParameters.SEARCH_STRING?if_exists}" style="width:173px;"/>
> 3. applications/order/webapp/ordermgr/entry/catalog/keywordsearchbox.ftl
> Change 
> <input type="text" name="SEARCH_STRING" size="14" maxlength="50" 
> value="${requestParameters.SEARCH_STRING?if_exists}"/>
> to
> <input type="text" name="SEARCH_STRING" size="14" maxlength="50" 
> value="${requestParameters.SEARCH_STRING?if_exists}" style="width:135px;"/>
> 4. 
> specialpurpose/ecommerce/webapp/ecommerce/customer/miniSignUpForContactList.ftl
> Change 
> <input size="20" maxlength="255" name="email" class="inputBox" value="" 
> type="text">
> to 
> <input size="20" maxlength="255" name="email" class="inputBox" value="" 
> type="text" style="width:135px;">

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to