+1 for your suggestion.

Though I have one concern here, currently names of data files suggests the kind of data they are holding. For example, AccountingTypeData.xml suggests that it has Type Data(including Enumeration), or DemoFinAccount.xml suggests it has demo data for FinAccount. This separation is nice. Also if we move all the seed data for a component to one specific file, it will grow too large affecting readability, and file for Demo Data can be much more larger. May be we can use the following format:
[Component-Name][Kind-of-Data(optional)][reader-name]Data.xml.

--
Thanks,
Mridul Pathak
HotWax Media Pvt. Ltd.
http://www.hotwaxmedia.com


On 05-Jun-09, at 12:59 PM, Adrian Crum wrote:


I was about to commit the change in the Asset Maintenance component (that our company uses OOTB) - but I realized that the change would have to include framework component changes. I ended up dropping the effort.

The bottom line is - it's an issue that has to be addressed (similar to the BigDecimal or the HTTP security issues we recently addressed) - but I'm not going to push it unless others see the benefit.

-Adrian


--- On Fri, 6/5/09, Jacques Le Roux <[email protected]> wrote:

From: Jacques Le Roux <[email protected]>
Subject: Re: Discussion: Seed and Demo Data Files
To: [email protected]
Date: Friday, June 5, 2009, 12:06 AM
+1 for differentiating data files
names
+1 for good examples commited (or if easier shown
somewhere)

Jacques

From: "Adrian Crum" <[email protected]>
I'm getting ready to deploy the latest trunk to our
production server, and I have encountered a few problems
with the way the seed data is set up.

In order to get the latest features to work with my
existing database, I have to run ant run-install-seed. The
problem is, there is a lot of demo data in the seed files.
And I really mean a LOT. After running run-install-seed, my
database contains a lot of demo data that I had previously
removed.

I would like to suggest the following best practices:

1. Keep seed-initial, seed, and demo data in separate
XML files.
2. Name the files accordingly, so their purpose is
clear. Example: [component name]InitialData.xml, [component
name]SeedData.xml, and [component name]DemoData.xml.

Right now I'm working on sorting out the data for the
accounting component. The AccountingSecurityData.xml file is
loaded as seed data, but it contains both seed AND demo
data: security permissions are seed data, assigning those
permissions to demo security groups is demo data. The
AccountingTypeData.xml file is loaded as seed data, but it
also contains both seed and demo data. Those are just two
examples.

I can commit some of my work as an example of what
changes need to be made.

What do you think?

-Adrian







Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to