If you are sharing code for review then its fine if you select the Granting flag most of the time. In your email you can mention that this code is for review only. Granting flag doesn't mean that your code will become part of OFBiz trunk. IMO it means that you are fine if all the code or part of code is committed into trunk and you are also fine if someone take your code (complete or partial) and use in his/ her custom application then you might not be having any objection with that.
In most of the cases(proportion remains 80% for inclusion - 20% for review) it happens that user submits patch and that are considered to become part of trunk. So adding "ASF Granted License" block will help developer as well as contributer to see whether that flag has been set or not. Lets see what other has to say about this. -- Ashish On Mon, Jun 22, 2009 at 9:57 PM, BJ Freeman <[email protected]> wrote: > the other side is alot of times I upload to have a review. > I don't select the License so it will not be committed. > so if default I would have to unselect and have the same problem. > > -- > BJ Freeman > http://www.businessesnetwork.com/automation > http://bjfreeman.elance.com > > http://www.linkedin.com/profile?viewProfile=&key=1237480&locale=en_US&trk=tab_pro > Systems Integrator. > >
