[ 
https://issues.apache.org/jira/browse/OFBIZ-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723038#action_12723038
 ] 

Vikas Mayur commented on OFBIZ-2650:
------------------------------------

Divesh, The changes looks okay. I have no problem with this sort of change 
except as mentioned below.

The Ui Label OrderCreateReturn and OrderReturnCreate though look same but have 
minor differences 

1) The language transformation for "nl" is different in both the labels. I am 
not sure which one is correct. Are you?
2) The language transformation for "ro" is not available in OrderCreateReturn 
so that means by deleting the label OrderReturnCreate this translation will be 
lost.

Vikas

> Capitalizing Create return --> Create Return of OrderUilabels.xml file for 
> maintaining consistency 
> ---------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2650
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2650
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Divesh Dutta
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OrderUiLabels_OFBiz_2650.patch, 
> OrderUiLabels_OFBiz_2650.patch
>
>
> Capitalizing Create return --> Create Return of OrderUilabels.xml file for 
> maintaining consistency 
> Also need to remove duplicate ui label for "Create Return"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to