Adam,
The service is returning id of two parties created in in the service.
I don't see anything bad about it. Can you please explain why is it
not good?

Also in this modification I have changed variable name used in method,
partyId out parameter was there before my this commit.

Regards
Anil Patel



On Jun 23, 2009, at 11:46 PM, Adam Heath wrote:

[email protected] wrote:
Author: apatel
Date: Wed Jun 24 02:48:28 2009
New Revision: 787890

URL: http://svn.apache.org/viewvc?rev=787890&view=rev
Log:
Minor code clean up in createLead service. Convert lead now expires relationship instead of deleting it.

Modified:
   ofbiz/trunk/applications/marketing/config/MarketingUiLabels.xml
ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/ LeadServices.xml

Modified: ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/ lead/LeadServices.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/LeadServices.xml?rev=787890&r1=787889&r2=787890&view=diff
= = = = = = = = = ===================================================================== --- ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/ LeadServices.xml (original) +++ ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/ LeadServices.xml Wed Jun 24 02:48:28 2009
@@ -52,15 +52,18 @@
                <set field="parameters.roleTypeId" value="LEAD"/>
<call-simple-method method- name="createPersonRoleAndContactMechs" xml-resource="component:// party/script/org/ofbiz/party/party/PartySimpleMethods.xml"/>
                <check-errors/>
+
+ <set field="leadContactPartyId" from- field="partyId"/>
+                <clear-field field="partyId"/>
<set field="partyRelationshipCtx.partyIdFrom" from- field="userLogin.partyId"/> - <set field="partyRelationshipCtx.partyIdTo" from- field="partyId"/> + <set field="partyRelationshipCtx.partyIdTo" from- field="leadContactPartyId"/>

Service is createLead, but returns leadContactPartyId?  That doesn't
seem sensible.

Reply via email to