[ 
https://issues.apache.org/jira/browse/OFBIZ-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733224#action_12733224
 ] 

Jacopo Cappellato commented on OFBIZ-2488:
------------------------------------------

Also,

in order to keep the code cleaner, it would be better to move the block:

+        if (otherValue != null && otherValue.contains("@")) {
+            shippingMethod = otherValue.substring(otherValue.indexOf("@")+1);
+            otherValue = "";
+        }

inside of the block:

+        } else if ("PPIP_ORDER_SHIPTOTAL".equals(inputParamEnumId) && 
shippingMethod.equals(cart.getShipmentMethodTypeId())) {
+            BigDecimal orderTotalShipping = cart.getTotalShipping();
+            if (Debug.verboseOn()) { Debug.logVerbose("Doing order total 
Shipping compare: ordertotalShipping=" + orderTotalShipping, module); }
+            compareBase = new Integer(orderTotalShipping.compareTo(new 
BigDecimal(condValue)));



> Support percentage discount on shipping for a specific shipping method
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-2488
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2488
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Divesh Dutta
>            Assignee: Vikas Mayur
>             Fix For: SVN trunk
>
>         Attachments: Shipping_Promotion-OFBIZ-2488.patch
>
>
> Support percentage discount on shipping for a specific shipping method. Also 
> associate this with promotion code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to