[ 
https://issues.apache.org/jira/browse/OFBIZ-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743210#action_12743210
 ] 

Scott Gray commented on OFBIZ-2753:
-----------------------------------

Yeah I do think it's high time that order editing was redesigned, although 
finding the time is always an issue.  Another problem that editing suffers from 
constantly is that people makes changes to the creation process but don't 
bother worry about editing so it always seems broken, the chain of events when 
saving an edit can be quite convoluted as well.

Regardless of when you reserve the inventory, you (well maybe not you 
specifically) will always need to be able to handle editing an order with 
inventory already reserved, potentially at any point up until the order is 
packed.  So yeah it would be quite possible to trigger reservation on a 
particular order item status but I don't think it will solve too many issues 
around editing.

I probably won't have time in the short term to work on this but any code or 
ideas that you come up with be appreciated.

> Cart that is loaded from an order has its orderId set to null
> -------------------------------------------------------------
>
>                 Key: OFBIZ-2753
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2753
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>
> ShoppingCartEvents.loadCartFromOrder has the following near the bottom of the 
> method:
>         // Since we only need the cart items, so set the order id as null
>         cart.setOrderId(null); 
> I believe this is ok with standard Ofbiz applications because the only time a 
> shopping cart is loaded from an order i when you wish to initiate the order 
> entry process from an existing order (you will be creating a new order).  In 
> our system however, you can start an order, persist it, and then pick it up 
> later to make more adjustments.  In this scenario the actual orderId should 
> be available (and accurate) to the order that was used for loading.
> Recommendation - create a new service method "initializeCartFromOrder" or 
> provide a parameter that indicates if the intent is to load into the cart for 
> initialization (vs. for existing order manipulation).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to