I was sure someone would answer this (I presumed the JDK name in createElementNS) but why should we make an exception here ? Most of the time, when you begin with exceptions you don't know where it will end. BTW, have we already such exceptions in OFBiz ?

Jacques

From: "Scott Gray" <[email protected]>
That's what Ashish originally named it but I asked him to change it so that it better reflected the underlying jdk method name createElementNS. Anyone who knows what that method does will immediately know what this one does.

Regards
Scott

On 26/08/2009, at 11:34 PM, Jacques Le Roux wrote:

I'd have prefered addChildElementNameSpaceValue as name

Jacques

From: <[email protected]>
Author: lektran
Date: Wed Aug 26 09:22:09 2009
New Revision: 807938

URL: http://svn.apache.org/viewvc?rev=807938&view=rev
Log:
Applied patch from Ashish Vijaywargiya that allows adding namespace  aware 
child elements via UtilXml

Modified:
  ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java

Modified: ofbiz/trunk/framework/base/src/org/ofbiz/base/util/ UtilXml.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java?rev=807938&r1=807937&r2=807938&view=diff
= = = = = = = = = 
=====================================================================
--- ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java  (original)
+++ ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java  Wed Aug 26 
09:22:09 2009
@@ -586,6 +586,17 @@
        newElement.appendChild(document.createTextNode(childElementValue));
       return newElement;
   }
+
+    /** Creates a child element with the given namespace  supportive name and 
appends it to the element child node list.
+     *  Also creates a Text node with the given value and appends  it to the 
new elements child node list.
+     */
+    public static Element addChildElementNSValue(Element element,  String 
childElementName,
+            String childElementValue, Document document, String  nameSpaceUrl) 
{
+        Element newElement =  document.createElementNS(nameSpaceUrl, 
childElementName);
+         newElement.appendChild(document.createTextNode(childElementValue));
+        element.appendChild(newElement);
+        return element;
+    }

   /** Creates a child element with the given name and appends it  to the 
element child node list.
    *  Also creates a CDATASection node with the given value and  appends it to 
the new elements child node list.





Reply via email to