The idea is to find a separator that will not be found in any string. BTW, that could be also a string and not a sole character, as
it's only used internally.
I suggested Nicolas to use ¤ (because I never found this character used in a string) but I guess he used µµ because he found a
problem with ¤.
Let's Nicolas talk about it...
Jacques
From: "Scott Gray" <[email protected]>
FYI, I now get the following warning during compilation:
[javac15] /Users/lektran/Documents/workspace/amazon/framework/
widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java:676:
warning: unmappable character for encoding UTF-8
[javac15] sr.append(menuString.replaceAll("\"", "??"));
Regards
Scott
On 3/09/2009, at 8:22 PM, [email protected] wrote:
Author: jleroux
Date: Thu Sep 3 08:22:49 2009
New Revision: 810807
URL: http://svn.apache.org/viewvc?rev=810807&view=rev
Log:
A patch from Nicolas Malin 'error whan parsing menu with " on screelet header'
https://issues.apache.org/jira/browse/OFBIZ-2873) - OFBIZ-2873
Modified:
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/
MacroScreenRenderer.java
ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl
Modified: ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/
MacroScreenRenderer.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java?rev=810807&r1=810806&r2=810807&view=diff
= = = = = = = =
======================================================================
--- ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/
MacroScreenRenderer.java (original)
+++ ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/
MacroScreenRenderer.java Thu Sep 3 08:22:49 2009
@@ -673,7 +673,7 @@
sr.append("\" padded=");
sr.append(Boolean.toString(padded));
sr.append(" menuString=\"");
- sr.append(menuString.replaceAll("\"", "'"));//FIXME change the " to '
for fix the macro invoke
+ sr.append(menuString.replaceAll("\"", "µµ"));
sr.append("\" showMore=");
sr.append(Boolean.toString(showMore));
sr.append(" collapsed=");
Modified: ofbiz/trunk/framework/widget/templates/ htmlScreenMacroLibrary.ftl
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl?rev=810807&r1=810806&r2=810807&view=diff
= = = = = = = =
======================================================================
--- ofbiz/trunk/framework/widget/templates/ htmlScreenMacroLibrary.ftl
(original)
+++ ofbiz/trunk/framework/widget/templates/ htmlScreenMacroLibrary.ftl Thu Sep
3 08:22:49 2009
@@ -94,7 +94,7 @@
 </a></li>
</#if>
<#if !collapsed>
-${menuString}
+${menuString?replace("µµ","\"")}
</#if>
</ul><br class="clear" /></div><div <#if collapsibleAreaId? has_content> id="${collapsibleAreaId}" <#if collapsed>
style="display: none;"</#if></#if><#if padded> class="screenlet- body"</#if>>
</#if>
