[
https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753080#action_12753080
]
Jacques Le Roux commented on OFBIZ-2628:
----------------------------------------
Hi Patrick,
Your patch looks good, though it's not an habit in OFBiz to put reference to
Jira issues in code. This afterall would add a lot of useless informations, we
try to keep the code as clean as possible.
I had a look at
http://freemarker.sourceforge.net/docs/ref_builtins_string.html#ref_builtin_url
and http://freemarker.sourceforge.net/docs/pgui_misc_charset.html, but I'd
still prefer to make the change in makeLink (I suppose you mean in the "encode
section") as
# it's used widely and not only in OfbizUrlTransform (look for references in
Eclipse)
# as you said putting ?url in templates would be wide and hazardous task (I
guess I did not check, using regexp replacement in Eclipse you can do miracles)
My 2 cts
> No Url encoding for get parameters
> ----------------------------------
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 4.0, Release Branch 9.04, SVN trunk
> Environment: All
> Reporter: Patrick Antivackis
> Priority: Critical
> Attachments: OFBIZ-2628-widget.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> Let's say I want to create a new category which ID is DVD+R
> Creation is ok through the admin interface, but whenever i want to access
> this category, the get parameter productCategoryId=.... of the url is wrong
> as it's not url encoded, so we have :
> https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD+R
> instead of
> https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR
> Both <@ofbizUrl> tag and menu widgets are not encoding get parameters.
> Way to correct :
> framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the
> makeLink function
> framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function
> buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of
> simpleEncoder
> Beofre i do the fix, can a core developper let me know about possible side
> effects
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
