[ 
https://issues.apache.org/jira/browse/OFBIZ-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759551#action_12759551
 ] 

Adrian Crum commented on OFBIZ-2969:
------------------------------------

Jeremy,

This patch looks good. If it is not too much trouble, could you also replace 
the calculate element with a UEL expression? It's not a requirement for 
committing, it's just a request - since you're already testing that section of 
code.

One of the nice things about UEL is we can replace the calculate element with 
simple UEL expressions. It would be nice to get these conversions into the 
project whenever we run across them.


> UEL errors in picklist services
> -------------------------------
>
>                 Key: OFBIZ-2969
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2969
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Adrian Crum
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: jira-2969.patch
>
>
> Like https://issues.apache.org/jira/browse/OFBIZ-2513 but in the other simple 
> methods.
> I had the problem in `getPickAndPackReportInfo` but since i was at it i also 
> fixed the other methods but did not test them.
> Patch coming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to