[
https://issues.apache.org/jira/browse/OFBIZ-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759883#action_12759883
]
Jacques Le Roux commented on OFBIZ-2493:
----------------------------------------
Hi Torstein,
Sorry but you need to read
http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices. At
least 2 issues in your patches. I looked only at ecommerce-product-detail.patch
and found a showstopper in the 1st change.
{code}
- if (defaultDetailImage == null || defaultDetailImage == "null" ||
defaultDetailImage == "") {
+ if (defaultDetailImage == null || defaultDetailImage == "null") {
{code}
This change you remove has been introduced in [revision
811528|http://markmail.org/message/beu46a6abvqvu35f] and I don't see any reason
to remove it. So please check that you have updated to last revision before
creating your patch since else you may introduce regressive bugs :(
Also please follow contributors best practices, you forgot this advice
"Eclipse internal command (don't use finish and select project to avoid the 2
1st lines in the patch)"
Thanks
> ECommerce - product detail: Centre screenlet drops below the lowest existing
> screenlet
> --------------------------------------------------------------------------------------
>
> Key: OFBIZ-2493
> URL: https://issues.apache.org/jira/browse/OFBIZ-2493
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: Release Branch 9.04
> Reporter: Torstein Hegbom
> Fix For: Release Branch 9.04
>
> Attachments: ecommerce-product-detail.patch,
> order-product-detail.patch
>
>
> The centre screenlet seems to not to have enouch space (in the x-direction)
> for the last screenlet added (product detail), and it drops below the lowest
> existing screenlet.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
