My opinion, for what it's worth:

Top posting: IDC

Commit comments: Adam's right, most of them are useless and might as well just say "changed stuff" all the time; I'm glad someone is complaining about this!

-David


On Sep 29, 2009, at 3:22 PM, Adrian Crum wrote:

A. Frowning upon top-posting.

Q. What causes those deep creases in the forehead?

Adam Heath wrote:
A: Because it changes the flow of a conversion.
Q: Why is top-posting frowned upon?
Scott Gray wrote:
Miscellaneous
They aren't.
* Access parameters thru the parameters map, instead of on the request
object directly.
* Use groovy empty object logic, instead of comparing values against
an empty string.
* Make use of groovy iteration support, thru each.
What I wrote explains it much better.  If there is some *real* error
that someone is trying to track down, and they see this 'misc changes'
log entry, they have no idea what was actually done, so they have to
run a diff of the changeset. If they see the above changelog entries,
then they know they can keep going, 'cuz more than likely it(the bug
they are trying to find) is not in this particular changeset.

Reply via email to