Re: svn commit: r820204 - in /ofbiz/trunk: applications/product/src/org/ofbiz/product/product/ProductSearchSession.java specialpurpose/ecommerce/data/DemoProduct.xml

[Scott Gray]

Inline

On 30/09/2009, at 11:57 PM, Ashish Vijaywargiya wrote:

Hello Scott,

Thanks for your comment.
Please see my comments inline:

On Wed, Sep 30, 2009 at 3:37 PM, Scott Gray <scott.g...@hotwaxmedia.com >wrote:

Hi Ashish

Comment inline

Regards
Scott

On 30/09/2009, at 9:03 PM, ash...@apache.org wrote:

Author: ashish

Date: Wed Sep 30 08:03:27 2009
New Revision: 820204

URL: http://svn.apache.org/viewvc?rev=820204&view=rev
Log:

entity. (This is what at present happening OOTB)

demo data then by default it will include variant products.

Modified:


ofbiz/trunk/specialpurpose/ecommerce/data/DemoProduct.xml

Modified:

URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearchSession.java?rev=820204&r1=820203&r2=820204&view=diff


---

(original)
+++

Wed Sep 30 08:03:27 2009
@@ -767,7 +767,7 @@
     }

     // check the ProductStore to see if we should add the
ExcludeVariantsConstraint
-        if (productStore != null &&
!"N".equals(productStore.getString("prodSearchExcludeVariants"))) {
+        if (productStore != null &&

         searchAddConstraint(new
ProductSearch.ExcludeVariantsConstraint(), session);

constraintsChanged = true;
     }

Putting the default value for prodSearchExcludeVariants=Y in ProductStore Also I had put a not-empty check so if someone forgot to put this value in ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ ProductSearchSession.java ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ ProductSearchSession.java = = = = = = = = = = ==================================================================== ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ ProductSearchSession.java ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ ProductSearchSession.java UtilValidate .isNotEmpty(productStore.getString("prodSearchExcludeVariants")) && !"N ".equals(productStore.getString("prodSearchExcludeVariants"))) { // not consider this a change for now, shouldn't change often:

Here you're change null == Y to null == N

hasn't set this value in the past.

I don't think it is a good idea to change the default behavior unless we have a good reason to do so, this would affect anyone taking an update who

Do you think that its good to exclude variant if no value is provided?

Personally I think it is most common that people would want variants excluded from the search results and only have the virtual product listed

I agree that after taking update someone will get affected by my change. Do you think it is ok if I revert my changes of Java code and keep the default

value as "Y" in demo data for prodSearchExcludeVariants?

Yes I think it fine to keep the demo data set to "Y", even though it has the same effect as leaving it out, the option becomes more explicit to anyone looking at the data.

Modified: ofbiz/trunk/specialpurpose/ecommerce/data/DemoProduct.xml

URL:
http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ecommerce/data/DemoProduct.xml?rev=820204&r1=820203&r2=820204&view=diff


08:03:27 2009
@@ -57,7 +57,7 @@

been disabled due to fraud."

continue to retry and notify you by email."

-        visualThemeId="EC_DEFAULT" autoApproveInvoice="Y"

+        visualThemeId="EC_DEFAULT" prodSearchExcludeVariants="Y"
autoApproveInvoice="Y" shipIfCaptureFails="Y" autoApproveOrder="Y"
showOutOfStockProducts="Y"/>

 <!-- <ProductStorePaymentSetting productStoreId="9000"

paymentService="testRandomAuthorize"/> -->
 <ProductStorePaymentSetting productStoreId="9000"

paymentService="alwaysApproveCCProcessor"
paymentCustomMethodId="CC_AUTH_ALWAYSAPPROV"/>

= = = = = = = = = = ==================================================================== --- ofbiz/trunk/specialpurpose/ecommerce/data/DemoProduct.xml (original) +++ ofbiz/trunk/specialpurpose/ecommerce/data/DemoProduct.xml Wed Sep 30 authFraudMessage="Your order has been rejected and your account has authErrorMessage="Problem connecting to payment processor; we will storeCreditValidDays="90" storeCreditAccountEnumId="FIN_ACCOUNT" shipIfCaptureFails="Y" autoApproveOrder="Y" showOutOfStockProducts="Y"/> paymentMethodTypeId="CREDIT_CARD" paymentServiceTypeEnumId="PRDS_PAY_AUTH" paymentMethodTypeId="CREDIT_CARD" paymentServiceTypeEnumId="PRDS_PAY_AUTH"

smime.p7s
Description: S/MIME cryptographic signature