[ 
https://issues.apache.org/jira/browse/OFBIZ-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-3099:
-----------------------------------

    Issue Type: Improvement  (was: Bug)

I did change from bug to improvment as I don't see really a bug here.

> PriceServices.calculateProductPrice should not process or return obsolete 
> PriceRules
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3099
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3099
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Patrick Antivackis
>             Fix For: SVN trunk
>
>         Attachments: Patch-OFBIZ-3099.txt
>
>
> There is no filterByDate done on the allProductPriceRules returned line 559.
> The consequences are that a findAllQuantityPrices=Y return a Map with some 
> obsolete PriceRule
> The calcPriceResultFromRules process some PriceRules that could be filtered 
> before.
> I don't see the point of returning all the PriceRules found when using 
> findAllQuantityPrices=Y as this map is used to display active price quantity 
> condition to the customer.
> If the service do need to return all PriceRules, as it is today, the service 
> should be updated in order to allow to specify if the returned list should be 
> only active or all.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to