[
https://issues.apache.org/jira/browse/OFBIZ-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771478#action_12771478
]
Adrian Crum commented on OFBIZ-3102:
------------------------------------
I looked through the patch quickly to get an understanding of the scope of work.
I'm puzzled about one change - if you remove the @SuppressWarnings("unchecked")
compiler directive in UelUtil.java, you add a compiler warning instead of
remove one.
A small suggestion - when creating templates for Java interfaces, try to use
the same template the Java interface uses (for consistency):
public static <X> String getMessage(String resource, String name, List<X>
arguments, Locale locale) {
would be better as
public static <E> String getMessage(String resource, String name, List<E>
arguments, Locale locale) {
http://java.sun.com/j2se/1.5.0/docs/api/java/util/List.html
> framework - base
> ----------------
>
> Key: OFBIZ-3102
> URL: https://issues.apache.org/jira/browse/OFBIZ-3102
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Bob Morley
> Attachments: OFBIZ-3102 base warning.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
