+1 for reverting the changes unless and until we find stable solution of problem with Jdk1.5. Thanks Jacques for your quick comment on this.
-- Ashish On Fri, Nov 13, 2009 at 2:50 PM, Jacques Le Roux < [email protected]> wrote: > I not totally sure but yet it seems that new versions of DBCP needs the 1.6 > jdk (or jdk 1.4) . Extract from README.TXT : <<This release of JDBC compiles > with and supports JDK 1.3 (JDBC 2.0), JDK 1.4-1.5 (JDBC 3.0) and JDK 1.6 > (JDBC 4.0). >> > > I tried to build with 1.5 but it failed and I began to find a way out, not > obvious... > > So the alternative is > 1) revert DBCP upgrade (fix a bug) > 2) Decide to use jdk 1.6 for OFBiz > > I would not like to push now for the 2d solution but as this upgrade was > intended to fix a bug, I wonder if it's not the right time > > In the meantime (before a decision is taken), I will continue to search a > solution to compile with 1.5 but does not seem easy (conditional ANT compile > deal with JDBC versions), and I'd not like to rewrite DBCP, even a part, > I've other fish to fry ;o) > > Jacques > > From: "Jacques Le Roux" <[email protected]> > > Thanks Adrian, >> >> Yes I did not care and build with ant from Eclipse where I use the 1.6 >> JDK. I'm on it, not as simple as I thought some problem >> appeared... >> In the meantime can you use 1.6 to build ? >> BTW, could we not change from 1.5 to 1.6, is there any blocking reasons I >> don't remember ? >> >> Jacques >> >> From: "Adrian Crum" <[email protected]> >> >>> Latest trunk: >>> >>> Compiling 129 source files to C:\ofbiz\framework\entity\build\classes >>> [javac15] >>> C:\ofbiz\framework\entity\src\org\ofbiz\entity\connection\DBCPConnectionFactory.java:21: >>> cannot access >>> org.apache.commons.dbcp.ConnectionFactory >>> [javac15] bad class file: >>> >>> C:\ofbiz\framework\entity\lib\commons-dbcp-1.3-20091111-r834702.jar(org/apache/commons/dbcp/ConnectionFactory.class) >>> [javac15] class file has wrong version 50.0, should be 49.0 >>> [javac15] Please remove or make sure it appears in the correct >>> subdirectory of the classpath. >>> [javac15] import org.apache.commons.dbcp.ConnectionFactory; >>> [javac15] ^ >>> [javac15] 1 error >>> >>> >>> >>> >>> >>> >> >> > >
