There is no doubt that there are synchronization issues in the Java code. I run 
across them all the time and fix them as I find them.

Maybe this is a good time to start a synchronization "Best Practices" thread 
where we can all offer our insights and suggestions so that poorly synchronized 
code is easier to notice and correct.

-Adrian


--- On Sat, 11/14/09, Jacques Le Roux <[email protected]> wrote:

> From: Jacques Le Roux <[email protected]>
> Subject: Re: Synchronisation issues
> To: [email protected]
> Date: Saturday, November 14, 2009, 6:58 AM
> From: "Adam Heath" <[email protected]>
> >> But before that I'd be interested to have some
> opinions by people who
> >> are using load balancers. Notably Brett who
> recently answered about this
> >> subject on user ML. Because I wonder why Philippe
> was the 1st to
> >> discover theses issues and if others have fixed
> them in another way.
> >
> > Using synchronization can cause deadlocks.  If
> you do not *fully*
> > control *all* code that is run under synchronization,
> then a deadlock
> > can occur.
> 
> I agree, synchronization is tricky. BTW, what to you think
> about r751619 ? Here is a remark about it
> https://issues.apache.org/jira/browse/OFBIZ-2186?focusedCommentId=12680105&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12680105
> 
> > If you call some other library, and said library is
> extensible, such
> > that it might end up calling *back* into your code,
> you *will* deadlock.
> 
> I agree, but I don't think it concerns this problem (I
> checked the Call Hierarchy)
> 
> > Non-blocking algorythms don't have this problem,
> because they retry in
> > these cases.
> 
> Sure, but a problem appeared here, it's well explained at
> https://issues.apache.org/jira/browse/OFBIZ-2124 and
> they propose a fix
> that works.
> It's not the 1st time this kind of problem appears. We have
> an opportunity to try a fix, this is the pragmatic reason of
> this
> message. What make me worry is that I'm sure there are
> other sites at least as much "big" as the one Philippe
> speaks about (but it's
> true it's a big one, at least in OFBiz world).
> 
> Others opinions ?
> 
> Jacques
> 
> 
> 



Reply via email to