Bilgin Ibryam wrote: > Adam Heath wrote: >> Adrian Crum wrote: >> >>> Developers, >>> >>> Please be careful when changing HTML element compounds. The recent >>> >> changes to certain themes are breaking the layout of the Flat Grey >> theme - which shouldn't have been affected. >> >> Um, huh? So, because *new* things were done, possibly adding more >> features, but it broke something else, you want to stop the new >> feature? Why not just fix the thing that broke? >> > I'm a little confused now, because in OFBiz Committers Roles and > Responsibilities is written this: > > *Rule #1 for a committer is the same as for a doctor:* *first do no > harm*. Nothing should be committed that breaks existing functionality > without replacing it either before or in the same commit.
Sure. But we are all human, and we are not perfect. Mistakes happen, in both directions. If someone breaks existing functionality, then either back out their change, or fix the existing code to make it work. In this case, I think that maybe just backing out the changes was the wrong approach to take. Unless they will come back at some point, with whatever problems fixed that they caused. ps: I haven't actually looked at the changes in question. > > Bilgin
