I think you are misunderstanding what happened and what I said.
Developing new themes is fine. Changing markup to suit one particular
theme is bad - because it breaks the other themes.
If the markup turns out to be a problem for ALL themes, then by all
means, let's change the markup.
-Adrian
Adam Heath wrote:
Adrian Crum wrote:
Developers,
Please be careful when changing HTML element compounds. The recent
changes to certain themes are breaking the layout of the Flat Grey
theme - which shouldn't have been affected.
Um, huh? So, because *new* things were done, possibly adding more
features, but it broke something else, you want to stop the new
feature? Why not just fix the thing that broke?
If we all thought your way, then nothing new would ever be done.
The changes that were just reversed base on your email, and the jira
issue you filed, should be reapplied.
Your jira issue should be closed as invalid, and a new one open,
listing what has *actually* been broken.
Whoever broke the Flat Grey layout, please put it back to the way it was
designed.
No, don't put it back. What if the correct fix is to fix flatgrey?
