Re: svn commit: r882210 [1/2] - in /ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting: ./ invoice/ payment/ period/ tax/ test/ thirdparty/clearcommerce/ thirdparty/gosoftware/ thirdparty/valuelink/ util/

[Scott Gray]

On 20/11/2009, at 9:16 AM, Adam Heath wrote:

=
=
=
=
=
=
=
=
=
=
=
===================================================================

---

(original)
+++

Thu Nov 19 17:26:03 2009
@@ -1158,7 +1158,7 @@
       return serviceResult;
   }

-    public static Map<String, Object>
createInvoicesFromShipments(DispatchContext dctx, Map context) {
+    public static Map<String, Object>

context) {
       Delegator delegator = dctx.getDelegator();
       LocalDispatcher dispatcher = dctx.getDispatcher();
       List<String> shipmentIds =
UtilGenerics.checkList(context.get("shipmentIds"));

ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/ invoice/InvoiceServices.java ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/ invoice/InvoiceServices.java createInvoicesFromShipments(DispatchContext dctx, Map<String, Object>

Nope, this is wrong.

Map<String, ? extends Object> context.

THIS IS A BUG.  PLEASE REVERT UNTIL IT IS FIXED.

The service engine *owns* the incoming context map.  Called services
are not allowed to change it *at all*.

There are already plenty of existing examples.


that modified the incoming context.  I then had to change their code
to deal with that problem.  This patch needs to have the same thing
done to it.

When I did similiar things to framework, I discovered several services

Hi Adam,

Could you explain a bit more?  When I look at the StandardJavaEngine
class the serviceInvoker method is specifically passing a Map<String,
Object> for the context.

serviceInvoker adds/removes things to this context, yes, so it has to
have that generics markup.  However, the things it calls *must* keep
it read-only, so that when several services in a chain are
called(think secas, service groups), once service can't affect another
in the set.

Regards
Scott

Thanks for the explanation, I won't pretend that I understand how using the same markup as the invoking method modifies the context though :-) I'll just flag this piece of generics as something I need to study up on.

smime.p7s
Description: S/MIME cryptographic signature