[ 
https://issues.apache.org/jira/browse/OFBIZ-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782519#action_12782519
 ] 

Jacques Le Roux commented on OFBIZ-3260:
----------------------------------------

Hi  Abdullah,

Your patch looks good, but please before creating new labels check that they 
don't already exist, for instance those one exist in OFBiz

<value xml:lang="en">Payment</value>
<value xml:lang="en">Deferred</value>
<value xml:lang="en">Release</value>
<value xml:lang="en">Cancel</value>
<value xml:lang="en">Abort</value>

Also it should be better to create the others in Common

Thanks

> Added drop down options replacing text box to configure sagepay
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-3260
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3260
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Abdullah Shaikh
>            Priority: Minor
>         Attachments: OFBIZ-3260_Added drop down options replacing text 
> box.patch
>
>
> Added drop down options, replacing text box, to configure SagePay payment 
> gateway transaction types settings.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to