Inline
David E Jones wrote:
On Nov 27, 2009, at 2:14 AM, Scott Gray wrote:
5. Is there a specific reason for keeping Old entities in trunk? Trunk users
should be already using the migration services and new entities?
Bilgin
Hi Bilgin,
I've never written a migration service, but aren't they dependent upon the old
entity definitions being present? I do agree though that we need to come up
with a timeframe for their removal at some point
You are right Scott, the migration service needs the old entity data. I
forgot about that. So it makes the removing of deprecated entities a bit
tricky.
We can move Old* entity to other files, but IMO they need to stay basically
forever in order to maintain an upgrade path. Without them upgrading becomes
very difficult.
If there was a case where and Old* entity was replaced by another Old* entity
(which was then in turn replaced by an entity currently in use) then maybe we
could consider getting rid of one of them, but IMO we still shouldn't because
it would mean that regardless of which one we get rid of a certain range of
revisions will not be upgradeable to the latest revision.
We could go down the path of requiring upgrades to go through a series of
changes, like to 4.0 to then to 09.04 then to trunk (or whatever other release
branches have been done). However, is it really that tough to keep this stuff
around? IMO it is really not at all a big deal.
If anyone is really bothered by messy stuff in the project then start cleaning
up and modernizing older code, but please let's not get so aggressive about
getting rid of stuff that is likely to be used.
-David
Thanks for the insight David !
