[
https://issues.apache.org/jira/browse/OFBIZ-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786738#action_12786738
]
Bruno Busco commented on OFBIZ-3274:
------------------------------------
Hi Adrian,
many thanks for the insight.
I partially agree with you:
I agree about the menus. A decorator-section should be used there. (I have put
this on my todo list)
But regarding the check on the section content I think the GD can do it if it
is necessary to render correctly the layout.
What I am trying to do with this patch is to have, at the end, the left-column
collapsible clicking on a little icon (disappearing toward left). This should
be globally and not only in one application.
In order to do this the GD checks the section content to use the right class
style for the divs.
Whenever an application want to put some content in the collapsible left column
simply put it into the "left-column" section and the column appears with the
possibility to have it collapsed or not.
Following this patters I would even let the VisualTheme to define a different
GD to have the greatest flexibility.
> Using decorator sections to control the left-bar
> ------------------------------------------------
>
> Key: OFBIZ-3274
> URL: https://issues.apache.org/jira/browse/OFBIZ-3274
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Assignee: Bruno Busco
> Attachments: OFBIZ-3274 DecoratorSectionLayout.patch, OFBIZ-3274
> DecoratorSectionLayout.patch
>
>
> Hi,
> at the moment, in order to have a screen rendered with or without a left bar,
> the variables "leftbarScreenName", "leftbarScreenLocation" and
> "MainColumnStyle" need to be set to select a screen for the left bar and a
> main column style.
> This must be done in the screen itself or an application decorator.
> With the attached patch, submitted for your review, a new GlobalDecorator
> section named "left-bar" has been added. If a screen must be displayed with a
> left bar this new decorator section needs to be filled with the selected
> content.
> The main column style is defined in the Global decorator. In order to do this
> a new screen condition has been added: "if-empty-decorator-section". This
> condition allows to check if a decorator section has been added content or
> not. (actually it only checks if the decorator section has been defined).
> In the patch I updated all catalog application screens to use this new method.
> If there are no problems with you with this, I will commit in the next days.
> Thank you for sharing your thoughts about.
> -Bruno
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
