[
https://issues.apache.org/jira/browse/OFBIZ-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798505#action_12798505
]
Bruno Busco commented on OFBIZ-3381:
------------------------------------
Erwan,
I agree perfectly with the idea in the patch.
Comments:
1) The FacilityLocationGeoLocation.ftl and PartyLocationGeoLocation.ftl should
then be eliminated
2) What is "fa = delegator.findByPrimaryKey("FixedAsset",
UtilMisc.toMap("fixedAssetId", fixedAssetId));
in FixedAssetGeoLocation.groovy" used for?
3) In partymgr on DemoCustomer1 clicking on
https://localhost:8443/partymgr/control/PartyGeoLocation?partyId=DemoCustomer1
I get an error:
org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen
[component://party/widget/partymgr/PartyScreens.xml#PartyGeoLocation]:
java.lang.NullPointerException: Cannot get property 'latitude' on null object
(Cannot get property 'latitude' on null object)
I quickly applied the patch. I don't know if I did some mistake.
Apart from this comments I agrre to have this committed.
> Update of the geolocation screen in party
> -----------------------------------------
>
> Key: OFBIZ-3381
> URL: https://issues.apache.org/jira/browse/OFBIZ-3381
> Project: OFBiz
> Issue Type: Improvement
> Components: party
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Erwan de FERRIERES
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3381.diff, OFBIZ-3381.diff, OFBIZ-3381.diff
>
>
> This will allow to use the new geoChart screen introduced by Bruno instead of
> the geoLocation screen, and then have less javascript calls.
> I put this as a JIRA issue to have your comments and be sure that this meet
> OFBiz requirements.
> if it's OK, I will then commit it to the trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
