[email protected] wrote: > Author: jacopoc > Date: Fri Jan 15 08:14:39 2010 > New Revision: 899557 > > URL: http://svn.apache.org/viewvc?rev=899557&view=rev > Log: > Based on suggestion by Adam Heath, the warning message is logged only if the > count is negative; if the count is zero the next for loop will be skipped and > the method will return true as well, but without warning message. > > Modified: > > ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/Loop.java > > Modified: > ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/Loop.java > URL: > http://svn.apache.org/viewvc/ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/Loop.java?rev=899557&r1=899556&r2=899557&view=diff > ============================================================================== > --- > ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/Loop.java > (original) > +++ > ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/Loop.java > Fri Jan 15 08:14:39 2010 > @@ -72,8 +72,8 @@ > return false; > } > > - if (count < 1) { > - Debug.logWarning("Count is less than one, not doing anything: " > + rawString(), module); > + if (count < 0) { > + Debug.logWarning("Count is less than zero, not doing anything: " > + rawString(), module); > return true; > }
Technically, this is a poor wording; negative counts are more an error, and probably shouldn't be happening.
