That's still a dependency on a higher level component. You're correct that you
can get lower-level things to not break when the higher-level component is
missing, but it's still backwards and really breaks the whole drop-in idea of
components. The component should have it's own ways of registering things with
the framework so that ANY component can be dropped in and not just one that the
framework is designed to support. That's where the dependency comes in, and
where flexibility goes out.
About the content component: I agree that certain parts of it should probably
be moved into the framework. There are a number of lower level things in it, ie
more tool-like things, in the content component.
It may be that parts of the party component make sense in the framework, but
most of it is not at all tool-like and makes no sense there. It is an important
base application and you're right that nearly every organization using OFBiz
will use it, but that doesn't mean it should go in the framework... the
framework is for technical level tools and not business level data management.
In any case, there's no reason to think of the party and content components as
entire components, if specific things seem to make sense in the framework let's
talk about that (and yes, I agree it needs discussing... we should have enough
content stuff in the framework to at least handle the help system).
-David
On Jan 18, 2010, at 8:21 PM, Hans Bakker wrote:
> Hi Scott,
>
> i have a solution which is already used a couple of times in the system:
>
> <set field="projectMgrExists"
> value="${groovy:org.ofbiz.base.component.ComponentConfig.componentExists("projectmgr")}"/>
>
> this statement will check if the projectmgr component exists in a form.
>
> would that help?
>
> Then we can use application functions in the framework without depending
> on it? Like the help screens?
>
> do a search on componentExists in the system and you will see more
> examples of that.
>
> Regards,
> Hans
>
>
>
> On Mon, 2010-01-18 at 18:55 -0700, Scott Gray wrote:
>> If you don't understand why the framework cannot depend on the applications
>> after all the discussions (and work) that has taken place over the years
>> then I am not about to attempt to explain it to you. I'm quite sure there
>> is a solution to this problem but introducing application dependencies in
>> the framework is not the right one.
>>
>> Regards
>> Scott
>>
>> On 18/01/2010, at 6:38 PM, Hans Bakker wrote:
>>
>>> Hi Scott,
>>>
>>> Can you explain to me what is wrong by using our own system content
>>> component for documentation? I personally think that for every business
>>> application you will need the party and content component anyway.
>>>
>>> regards,
>>> Hans
>>>
>>> On Mon, 2010-01-18 at 18:27 -0700, Scott Gray wrote:
>>>> But what about webtools, example and birt? IMO the real problem is that
>>>> you want to document framework screens using the content application and
>>>> this is the problem that needs to be solved.
>>>>
>>>> Regards
>>>> Scott
>>>>
>>>> HotWax Media
>>>> http://www.hotwaxmedia.com
>>>>
>>>> On 18/01/2010, at 6:14 PM, Hans Bakker wrote:
>>>>
>>>>> I personally do not think the bi component should be in the framework,
>>>>> it should be in the commonext component.
>>>>> 1. it does business reporting and needs the applications
>>>>> 2. especially it needs help screens what is also not possible in the
>>>>> framework.
>>>>> 3. its function is also to initialize the bi entities which are located
>>>>> in the applications.
>>>>>
>>>>> so i would propose to move it and your problems are solved at the same
>>>>> time.
>>>>>
>>>>> On Mon, 2010-01-18 at 18:27 +0000, [email protected] wrote:
>>>>>> Author: lektran
>>>>>> Date: Mon Jan 18 18:27:35 2010
>>>>>> New Revision: 900497
>>>>>>
>>>>>> URL: http://svn.apache.org/viewvc?rev=900497&view=rev
>>>>>> Log:
>>>>>> Removed or commented all references to the commonext component from the
>>>>>> framework, this may will break some things but the dependency should
>>>>>> never have been introduced in the first place and needs to be fixed.
>>>>>> Inspired by OFBIZ-3329 but I don't believe it resolves that issue.
>>>>>>
>>>>>> Modified:
>>>>>> ofbiz/trunk/framework/bi/webapp/bi/WEB-INF/controller.xml
>>>>>> ofbiz/trunk/framework/example/webapp/birt/WEB-INF/controller.xml
>>>>>> ofbiz/trunk/framework/example/webapp/example/WEB-INF/controller.xml
>>>>>> ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/controller.xml
>>>>>>
>>>>>> Modified: ofbiz/trunk/framework/bi/webapp/bi/WEB-INF/controller.xml
>>>>>> URL:
>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/bi/webapp/bi/WEB-INF/controller.xml?rev=900497&r1=900496&r2=900497&view=diff
>>>>>> ==============================================================================
>>>>>> --- ofbiz/trunk/framework/bi/webapp/bi/WEB-INF/controller.xml (original)
>>>>>> +++ ofbiz/trunk/framework/bi/webapp/bi/WEB-INF/controller.xml Mon Jan 18
>>>>>> 18:27:35 2010
>>>>>> @@ -22,7 +22,6 @@
>>>>>>
>>>>>> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd";>
>>>>>>
>>>>>> <include
>>>>>> location="component://common/webcommon/WEB-INF/common-controller.xml"/>
>>>>>> - <include
>>>>>> location="component://commonext/webapp/WEB-INF/controller.xml"/>
>>>>>> <description>Business Intelligence Component Site Configuration
>>>>>> File</description>
>>>>>>
>>>>>> <!-- Request Mappings -->
>>>>>>
>>>>>> Modified:
>>>>>> ofbiz/trunk/framework/example/webapp/birt/WEB-INF/controller.xml
>>>>>> URL:
>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/example/webapp/birt/WEB-INF/controller.xml?rev=900497&r1=900496&r2=900497&view=diff
>>>>>> ==============================================================================
>>>>>> --- ofbiz/trunk/framework/example/webapp/birt/WEB-INF/controller.xml
>>>>>> (original)
>>>>>> +++ ofbiz/trunk/framework/example/webapp/birt/WEB-INF/controller.xml Mon
>>>>>> Jan 18 18:27:35 2010
>>>>>> @@ -24,7 +24,6 @@
>>>>>> can be found in the following xml file. A component can override
>>>>>> the
>>>>>> elements found in the common-controller.xml file. -->
>>>>>> <include
>>>>>> location="component://common/webcommon/WEB-INF/common-controller.xml"/>
>>>>>> - <include
>>>>>> location="component://commonext/webapp/WEB-INF/controller.xml"/>
>>>>>>
>>>>>> <description>Birt Component Site Configuration File</description>
>>>>>> <owner>Copyright 2001-2008 The Apache Software Foundation</owner>
>>>>>>
>>>>>> Modified:
>>>>>> ofbiz/trunk/framework/example/webapp/example/WEB-INF/controller.xml
>>>>>> URL:
>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/example/webapp/example/WEB-INF/controller.xml?rev=900497&r1=900496&r2=900497&view=diff
>>>>>> ==============================================================================
>>>>>> --- ofbiz/trunk/framework/example/webapp/example/WEB-INF/controller.xml
>>>>>> (original)
>>>>>> +++ ofbiz/trunk/framework/example/webapp/example/WEB-INF/controller.xml
>>>>>> Mon Jan 18 18:27:35 2010
>>>>>> @@ -265,8 +265,10 @@
>>>>>> <view-map name="ListExampleFormOnly" type="screen"
>>>>>> page="component://example/widget/example/ExampleAjaxScreens.xml#ListExampleFormOnly"/>
>>>>>> <view-map name="CreateExampleFormOnly" type="screen"
>>>>>> page="component://example/widget/example/ExampleAjaxScreens.xml#CreateExampleFormOnly"/>
>>>>>> <view-map name="printExampleFOPFonts" type="screenfop"
>>>>>> page="component://example/widget/example/FormWidgetExampleScreens.xml#printExampleFOPFonts"
>>>>>> content-type="application/pdf" encoding="none"/>
>>>>>> + <!-- Commenting these out because commonext is an application
>>>>>> component and shouldn't be referred to from the framework
>>>>>> <view-map name="showHelp" type="screen"
>>>>>> page="component://commonext/widget/HelpScreens.xml#ShowHelp"/>
>>>>>> <view-map name="ShowDocument" type="screen"
>>>>>> page="component://commonext/widget/HelpScreens.xml#showDocument"/>
>>>>>> + -->
>>>>>>
>>>>>> <view-map name="ExampleGeoLocationPointSet1" type="screen"
>>>>>> page="component://example/widget/example/ExampleScreens.xml#ExampleGeoLocationPointSet1"/>
>>>>>> <view-map name="ExampleGeoLocationPointSet2" type="screen"
>>>>>> page="component://example/widget/example/ExampleScreens.xml#ExampleGeoLocationPointSet2"/>
>>>>>>
>>>>>> Modified:
>>>>>> ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/controller.xml
>>>>>> URL:
>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/controller.xml?rev=900497&r1=900496&r2=900497&view=diff
>>>>>> ==============================================================================
>>>>>> ---
>>>>>> ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/controller.xml
>>>>>> (original)
>>>>>> +++
>>>>>> ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/controller.xml
>>>>>> Mon Jan 18 18:27:35 2010
>>>>>> @@ -21,7 +21,6 @@
>>>>>> <site-conf xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>>>>>>
>>>>>> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd";>
>>>>>> <include
>>>>>> location="component://common/webcommon/WEB-INF/common-controller.xml"/>
>>>>>> - <include
>>>>>> location="component://commonext/webapp/WEB-INF/controller.xml"/>
>>>>>> <include
>>>>>> location="component://common/webcommon/WEB-INF/tempexpr-controller.xml"/>
>>>>>> <include
>>>>>> location="component://testtools/webapp/testtools/WEB-INF/controller.xml"/>
>>>>>> <description>WebTools Site Configuration File</description>
>>>>>>
>>>>>>
>>>>> --
>>>>> Antwebsystems.com: Quality OFBiz services for competitive rates
>>>>>
>>>>
>>> --
>>> Antwebsystems.com: Quality OFBiz services for competitive rates
>>>
>>
> --
> Antwebsystems.com: Quality OFBiz services for competitive rates
>
