On 22/01/2010, at 10:21 AM, Adrian Crum wrote:

> Adam Heath wrote:
>> Adrian Crum wrote:
>>> Adam Heath wrote:
>>>> Adrian Crum wrote:
>>>>> Scott Gray wrote:
>>>>>> On 22/01/2010, at 8:03 AM, Erwan de FERRIERES wrote:
>>>>>> 
>>>>>>> Hi all,
>>>>>>> 
>>>>>>> there is still some compiler warnings in the trunk.
>>>>>>> 
>>>>>>> I've list those files with calls to deprecated methods :
>>>>>>> * OFBizBirtViewerReportService.java (call to a
>>>>>>> org.eclipse.birt.report.service.ReportEngineService.DummyRemoteException
>>>>>>> 
>>>>>>> which is deprecated)
>>>>>>> * UtilXml.java (this import : org.apache.xml.serialize.OutputFormat
>>>>>>> is deprecated)
>>>>>>> * JSONSimpleEventHandler.java (the AbstractJSONEventHandler has been
>>>>>>> deprecated).
>>>>>> I couldn't seem to disable this warning regardless of where I put the
>>>>>> suppress warnings annotation, if anyone has some pointers I'll be glad
>>>>>> to hear them.
>>>>> I think it is safe to remove the deprecated class from UtilXml now. The
>>>>> method that uses it has been deprecated for nearly a year now.
>>>> Is it in a release?
>>> Yes.
>> Was it deprecated in the *last* release, or was deprecated added
>> during *this* development cycle?  If the former, then you can remove
>> it.  If the latter, it has to stay for the next release.
>> If I'm causing you(or whoever goes about fixing these) too much work,
>> then I'm sorry, but this is what is required for proper release
>> management.
> 
> Understood. It was deprecated after the last release. It isn't causing anyone 
> too much work - it just produces an annoying compiler warning.
> 

A good majority of the deprecated methods prior to the last release were 
deprecated using the javadoc style: /** @deprecated */
I updated them post release to use the actual @Deprecated annotation, any 
opinions on whether we're okay to remove them now or would we be better to wait?

Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to