Hi Adam,

is it possible to get a suggestion how to do this better? We still
appreciate you technical knowledge :-) !

Regards,
Hans

On Wed, 2010-02-03 at 10:53 -0600, Adam Heath wrote:
> [email protected] wrote:
> > Author: hansbak
> > Date: Tue Feb  2 03:18:15 2010
> > New Revision: 905500
> > 
> > URL: http://svn.apache.org/viewvc?rev=905500&view=rev
> > Log:
> > make birt use the itext libraries already present in ofbiz, contribution of 
> > Chattree and reported by erwan in the mailing list
> > 
> > Added:
> >     ofbiz/trunk/framework/birt/lib/platform/plugins/com.lowagie.itext/
> >     
> > ofbiz/trunk/framework/birt/lib/platform/plugins/com.lowagie.itext/META-INF/
> >     
> > ofbiz/trunk/framework/birt/lib/platform/plugins/com.lowagie.itext/META-INF/MANIFEST.MF
> >     
> > ofbiz/trunk/framework/birt/lib/platform/plugins/com.lowagie.itext/plugin.properties
> > Removed:
> >     
> > ofbiz/trunk/framework/birt/lib/platform/plugins/com.lowagie.itext_1.5.4.v20090305/
> > Modified:
> >     ofbiz/trunk/LICENSE
> > 
> > Modified: ofbiz/trunk/LICENSE
> > URL: 
> > http://svn.apache.org/viewvc/ofbiz/trunk/LICENSE?rev=905500&r1=905499&r2=905500&view=diff
> > ==============================================================================
> > --- ofbiz/trunk/LICENSE (original)
> > +++ ofbiz/trunk/LICENSE Tue Feb  2 03:18:15 2010
> > @@ -2462,8 +2462,6 @@
> >  
> > ofbiz/trunk/framework/birt/lib/platform/plugins/org.w3c.css.sac_1.3.0.v200805290154.jar
> >  
> > ofbiz/trunk/framework/birt/lib/platform/plugins/org.w3c.dom.smil_1.0.0.v200806040011.jar
> >  
> > ofbiz/trunk/framework/birt/lib/platform/plugins/org.w3c.dom.svg_1.1.0.v200806040011.jar
> > -ofbiz/trunk/framework/birt/lib/platform/plugins/com.lowagie.itext_1.5.4.v20090608/lib/itext_1.5.4.jar
> > -ofbiz/trunk/framework/birt/lib/platform/plugins/com.lowagie.itext_1.5.4.v20090608/lib/itextasian-1.5.2.jar
> >  
> > ofbiz/trunk/framework/birt/lib/platform/plugins/org.eclipse.core.runtime.compatibility.registry_3.2.200.v20090429-1800/runtime_registry_compatibility.jar
> >  
> > ofbiz/trunk/framework/birt/lib/platform/plugins/org.mozilla.rhino_1.7.1.v20090608/lib/js.jar
> >  
> > ofbiz/trunk/framework/birt/lib/platform/plugins/org.w3c.sac_1.3.0.v20090608/lib/flute.jar
> > 
> > Added: 
> > ofbiz/trunk/framework/birt/lib/platform/plugins/com.lowagie.itext/META-INF/MANIFEST.MF
> > URL: 
> > http://svn.apache.org/viewvc/ofbiz/trunk/framework/birt/lib/platform/plugins/com.lowagie.itext/META-INF/MANIFEST.MF?rev=905500&view=auto
> > ==============================================================================
> > --- 
> > ofbiz/trunk/framework/birt/lib/platform/plugins/com.lowagie.itext/META-INF/MANIFEST.MF
> >  (added)
> > +++ 
> > ofbiz/trunk/framework/birt/lib/platform/plugins/com.lowagie.itext/META-INF/MANIFEST.MF
> >  Tue Feb  2 03:18:15 2010
> > @@ -0,0 +1,22 @@
> 
> Where is the license header?
> 
> > +Manifest-Version: 1.0
> > +Bundle-Vendor: %providerName
> > +Bundle-Name: %pluginName
> 
> Are these 2 correct?
> 
> > +Bundle-Localization: plugin
> > +Bundle-RequiredExecutionEnvironment: J2SE-1.4
> > +Bundle-SymbolicName: com.lowagie.itext
> > +Eclipse-ExtensibleAPI: true
> > +Bundle-Version: 1.5.4.v20090305
> > +Bundle-ClassPath: ../../../../../webapp/lib/itext-2.0.1.jar
> 
> I don't like this.  Not at all.  Hard-coded library paths scattered
> all over is icky.
> 
> It would be better to automatically build this file using targets in
> build.xml, and automatically finding the correct itext.jar file path.
>  Plus doing this for the other unpacked plugins.
> 
> (for all): ant is not just for compiling java into class.  It can
> produce a lot more.  Don't be afraid to do xml+xslt to produce shell
> scripts, or properties files, or variable replacement in text blobs.
> 
> > +Export-Package: com.lowagie.bc.asn1,com.lowagie.text,com.lowagie.text.
> > + html,com.lowagie.text.html.simpleparser,com.lowagie.text.markup,com.l
> > + owagie.text.pdf,com.lowagie.text.pdf.codec,com.lowagie.text.pdf.codec
> > + .wmf,com.lowagie.text.pdf.crypto,com.lowagie.text.pdf.events,com.lowa
> > + gie.text.pdf.fonts,com.lowagie.text.pdf.hyphenation,com.lowagie.text.
> > + rtf,com.lowagie.text.rtf.direct,com.lowagie.text.rtf.document,com.low
> > + agie.text.rtf.document.output,com.lowagie.text.rtf.field,com.lowagie.
> > + text.rtf.graphic,com.lowagie.text.rtf.headerfooter,com.lowagie.text.r
> > + tf.list,com.lowagie.text.rtf.style,com.lowagie.text.rtf.table,com.low
> > + agie.text.rtf.text,com.lowagie.text.xml,com.lowagie.text.xml.xmp,com.
> > + lowagie.tools
> > +Bundle-ManifestVersion: 2
> > +Bundle-Copyright: Copyright 2001-2009 The Apache Software Foundation
> > \ No newline at end of file
> > 
> > Added: 
> > ofbiz/trunk/framework/birt/lib/platform/plugins/com.lowagie.itext/plugin.properties
> > URL: 
> > http://svn.apache.org/viewvc/ofbiz/trunk/framework/birt/lib/platform/plugins/com.lowagie.itext/plugin.properties?rev=905500&view=auto
> > ==============================================================================
> > --- 
> > ofbiz/trunk/framework/birt/lib/platform/plugins/com.lowagie.itext/plugin.properties
> >  (added)
> > +++ 
> > ofbiz/trunk/framework/birt/lib/platform/plugins/com.lowagie.itext/plugin.properties
> >  Tue Feb  2 03:18:15 2010
> > @@ -0,0 +1,17 @@
> > +#####################################################################
> > +# Copyright 2001-2009 The Apache Software Foundation
> > +#
> > +# Licensed under the Apache License, Version 2.0 (the "License"); you may 
> > not
> > +# use this file except in compliance with the License. You may obtain a 
> > copy of
> > +# the License at
> > +#
> > +# http://www.apache.org/licenses/LICENSE-2.0
> > +#
> > +# Unless required by applicable law or agreed to in writing, software
> > +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
> > +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
> > +# License for the specific language governing permissions and limitations
> > +# under the License.
> > +#####################################################################
> > +pluginName = Lowagie Itext
> > +providerName = Apache Open For Business Project
> > 
> > 
> 
-- 
Antwebsystems.com: Quality OFBiz services for competitive rates

Reply via email to