[email protected] wrote: > Author: erwan > Date: Thu Feb 11 09:39:44 2010 > New Revision: 908897 > > URL: http://svn.apache.org/viewvc?rev=908897&view=rev > Log: > Formating the error message in userLogin Service : adding spaces in error > messages > (https://issues.apache.org/jira/browse/OFBIZ-3460) OFBIZ-3460 > > Modified: > ofbiz/trunk/framework/common/src/org/ofbiz/common/login/LoginServices.java > > Modified: > ofbiz/trunk/framework/common/src/org/ofbiz/common/login/LoginServices.java > URL: > http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/src/org/ofbiz/common/login/LoginServices.java?rev=908897&r1=908896&r2=908897&view=diff > ============================================================================== > --- > ofbiz/trunk/framework/common/src/org/ofbiz/common/login/LoginServices.java > (original) > +++ > ofbiz/trunk/framework/common/src/org/ofbiz/common/login/LoginServices.java > Thu Feb 11 09:39:44 2010 > @@ -383,16 +383,16 @@ > errMsg = > UtilProperties.getMessage(resource,"loginservices.account_for_user_login_id_disabled",messageMap > ,locale); > if (disabledDateTime != null) { > messageMap = UtilMisc.<String, > Object>toMap("disabledDateTime", disabledDateTime); > - errMsg += > UtilProperties.getMessage(resource,"loginservices.since_datetime",messageMap > ,locale); > + errMsg += " " + > UtilProperties.getMessage(resource,"loginservices.since_datetime",messageMap > ,locale); > } else { > errMsg += "."; > } > > if (loginDisableMinutes > 0 && reEnableTime != null) > { > messageMap = UtilMisc.<String, > Object>toMap("reEnableTime", reEnableTime); > - errMsg += > UtilProperties.getMessage(resource,"loginservices.will_be_reenabled",messageMap > ,locale); > + errMsg += " " + > UtilProperties.getMessage(resource,"loginservices.will_be_reenabled",messageMap > ,locale); > } else { > - errMsg += > UtilProperties.getMessage(resource,"loginservices.not_scheduled_to_be_reenabled",locale); > + errMsg += " " + > UtilProperties.getMessage(resource,"loginservices.not_scheduled_to_be_reenabled",locale); > } > } > } else {
Don't use +, use a StringBuilder. Don't do conditional concatenation in the code for messages, do that in the label. This may require adding support for actually doing conditions in labels. What do others things?
