[email protected] wrote:
Author: doogie
Date: Sun Feb 14 22:36:46 2010
New Revision: 910100
URL: http://svn.apache.org/viewvc?rev=910100&view=rev
Log:
getSourceClass and getTargetClass are no longer final.
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/AbstractConverter.java
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/AbstractConverter.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/AbstractConverter.java?rev=910100&r1=910099&r2=910100&view=diff
==============================================================================
---
ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/AbstractConverter.java
(original)
+++
ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/AbstractConverter.java
Sun Feb 14 22:36:46 2010
@@ -42,11 +42,11 @@
return ObjectType.instanceOf(sourceClass, this.getSourceClass()) &&
ObjectType.instanceOf(targetClass, this.getTargetClass());
}
- public final Class<? super S> getSourceClass() {
+ public Class<? super S> getSourceClass() {
return sourceClass;
}
- public final Class<? super T> getTargetClass() {
+ public Class<? super T> getTargetClass() {
return targetClass;
}
}
As a general rule, I try to avoid declaring methods as final in OFBiz,
because there is always a chance a user might want to override the
method. For the same reason I prefer using protected over private.
