On Feb 15, 2010, at 10:22 AM, Adam Heath wrote: > [email protected] wrote: >> Author: doogie >> Date: Sun Feb 14 22:41:19 2010 >> New Revision: 910110 >> >> URL: http://svn.apache.org/viewvc?rev=910110&view=rev >> Log: >> Implement a creation framework; this allows creaters to provide >> optimized versions of converters. >> >> Added: >> >> ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/ConverterCreater.java >> Modified: >> ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/Converters.java > > This is the commit that broke the build. > > What happened here, is I had tested an earlier version of this change, > and everything worked(localized tests in base, and full system tests). > I then changed the commit, and got excited about committing > everything, so didn't go thru a full test cycle. > > Ideally, going forward, to help solve this, we need to have full > coverage of base; using cobertura, you can see what lines are being > run. I am currently getting the conversion system to something close > to 100%. If it had more coverage, this problem would have been > discovered with the simple tests.
I think I'm missing something here... how does this relate to a failure to run tests? Another small and insignificant detail to consider is that: 100% coverage does not mean 100% bug-free, unless perhaps you are a marketing professional. -David
