David E Jones wrote: > On Feb 26, 2010, at 10:33 AM, Adam Heath wrote: > >> Adam Heath (JIRA) wrote: >>> [ >>> https://issues.apache.org/jira/browse/OFBIZ-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel >>> ] >>> >>> Adam Heath updated OFBIZ-3520: >>> ------------------------------ >>> >>> Attachment: 897606-testcase.patch >>> >>>> revision 897605 breaks certain delegator.find() EntityListIterator calls >>>> ------------------------------------------------------------------------ >>>> >>>> Key: OFBIZ-3520 >>>> URL: https://issues.apache.org/jira/browse/OFBIZ-3520 >>>> Project: OFBiz >>>> Issue Type: Bug >>>> Components: framework >>>> Affects Versions: SVN trunk >>>> Reporter: Adam Heath >>>> Assignee: David E. Jones >>>> Attachments: 897606-testcase.patch >>>> >>>> >>>> We recently upgraded our internal ofbiz package to a newer trunk version, >>>> one from the end of January. Ean then deployed that to the server it was >>>> developing on. This broke requirements processing. I have reduced it, >>>> however, to a simple patch, that works if I revert 897606, but breaks when >>>> it is applied. >>>> Test case will be attached. >> David, could you please take a look at this, as it is your commit that >> causes this to break. > > Did you read the discussion about this? > > Just search for the revision number. > > I believe it has already been fixed, and you'll either have to update to > something more recent or back-port the fix. > > On a side note, so what if my commit caused it to break? Does that mean that > only I can fix it? What a depressingly disempowering notion. > > -David
My test case is against trunk. It doesn't work in trunk. When I undo 897606, it works again. What does that have to do with any other kind of fix for any other part of the system? I tried looking at the commit(it's small), but didn't fully understand the situation in which is is useful. Since you did the commit, I figured you'd know more about what was going on. Of course others can look at it, nothing is stopping them. But you obviously know more about this, as you are the one who did the change. Why do you have to be so combative? > >
