[
https://issues.apache.org/jira/browse/OFBIZ-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840569#action_12840569
]
Jacques Le Roux commented on OFBIZ-3530:
----------------------------------------
A comment from Bruno about the lookups icons on dev ML:
{quote}
This is not related to the theme itself but must be fixed in the FTL files.
What happens is that the FTL files renders the lookup fields with a
different HTML from what is rendered by the form widget.
In order to make OFBiz more consistent we need to have the FTL
generate the same HTML structure as the form widget and not to have
the theme do all the work to handle all variants of things.
The lookups in the FTL in https://ofbiz-vm.apache.org/catalog/control/main
have this HTML:
{code}
<div>
<label for="keywordSearchCategoryId">Category ID:</label>
<input type="text" name="SEARCH_CATEGORY_ID" id="keywordSearchCategoryId"
size="15" maxlength="20" value=""/>
<a
href="javascript:call_fieldlookup2($('keywordSearchCategoryId'),'LookupProductCategory');">
<img src='/images/fieldlookup.gif' width='15' height='14' alt="Click here
For Field Lookup" />
</a>
</div>
{code}
but if you go in
https://ofbiz-vm.apache.org/assetmaint/control/EditFixedAsset?fixedAssetId=DEMO_PROJECTOR
you will see that the lookups have this HTML:
{code}
<div class="field-lookup">
<ul>
<li><input type="text" name="parentFixedAssetId" size="25"
id="EditFixedAsset_parentFixedAssetId"/></li>
<li>
<a
href="javascript:call_fieldlookup2(document.EditFixedAsset.parentFixedAssetId,'LookupFixedAsset');">
<span id="EditFixedAsset_parentFixedAssetId_indicator"
style="display:none" class="indicator">
<img/>
</span>
</a>
</li>
</ul>
</div>
{code}
Using this HTML *all* the themes already handle it very well. Every theme can
specify a different icon and tomahawk uses a very nice card icon with a
transparent background.
{quote}
> Litle quirks in Party component
> -------------------------------
>
> Key: OFBIZ-3530
> URL: https://issues.apache.org/jira/browse/OFBIZ-3530
> Project: OFBiz
> Issue Type: Sub-task
> Components: party
> Affects Versions: SVN trunk
> Reporter: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: screenshot-1.jpg, screenshot-2.jpg, screenshot-3.jpg,
> screenshot-4.jpg, screenshot-5.jpg, screenshot-6.jpg, screenshot-7.jpg,
> screenshot-8.jpg, screenshot-9.jpg
>
>
> While working on the layered lookup I found some quirks in the Party
> Component. I think most of them certainly exist also in other components
> since they look more like neglicted CSS and fixing them here will fix a lot
> of other places. Still these buttons looks inconsistency, I think we should
> definitively tackle that and get it out of OFBiz.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
