Omg. I'm floored. ShoppingCartItem.getSize() does not deal with uom *at all*. Then, that method is so very broken; it has no idea how to do volume at all!
length, width, height is used to calculate the volume. And the algorithm it uses is... wait for it... (length+length)+(width+width)+height Surface area of a cube: 2a*b + 2b*c + 2a*c Volume of a cube: a*b*c getSize() is none of these. ShoppingCart.getShippableWeight(int) is also very broken. It doesn't deal with uom at all. What if I order a case of something, that is measured in pounds, then only a singleton item, that is measured in ounces? getShippableWeight just sums up the weights of all the cart items. I've looked in the history, and these issues have been unchanged since July, 2006, when ofbiz was imported to apache. This would also have breakage for any kind of automatic assignment into shipping containers when planning a shipment.
