Scott Gray wrote: > On 17/03/2010, at 12:49 PM, Adam Heath wrote: > >> Scott Gray wrote: >>> On 17/03/2010, at 12:16 PM, Adam Heath wrote: >>> >>>> Scott Gray wrote: >>>>> On 17/03/2010, at 11:53 AM, Adam Heath wrote: >>>>> >>>>>> [email protected] wrote: >>>>>>> Author: lektran >>>>>>> Date: Wed Mar 17 17:28:01 2010 >>>>>>> New Revision: 924378 >>>>>>> >>>>>>> URL: http://svn.apache.org/viewvc?rev=924378&view=rev >>>>>>> Log: >>>>>>> Tabs to spaces >>>>>>> Modified: ofbiz/trunk/ant >>>>>>> URL: >>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/ant?rev=924378&r1=924377&r2=924378&view=diff >>>>>>> ============================================================================== >>>>>>> --- ofbiz/trunk/ant (original) >>>>>>> +++ ofbiz/trunk/ant Wed Mar 17 17:28:01 2010 >>>>>>> @@ -26,14 +26,14 @@ else >>>>>>> fi >>>>>>> >>>>>>> find_jar() { >>>>>>> - top="$(cd "$(dirname "$0")"; echo "$PWD")" >>>>>>> - set -- "$top"/framework/base/lib/ant-launcher-*.jar >>>>>>> - if [ $# = 1 ] && [ -e "$1" ]; then >>>>>>> - echo "$1" >>>>>>> - else >>>>>>> - echo "Couldn't find ant-launcher.jar" 1>&2 >>>>>>> - exit 1 >>>>>>> - fi >>>>>>> + top="$(cd "$(dirname "$0")"; echo "$PWD")" >>>>>>> + set -- "$top"/framework/base/lib/ant-launcher-*.jar >>>>>>> + if [ $# = 1 ] && [ -e "$1" ]; then >>>>>>> + echo "$1" >>>>>>> + else >>>>>>> + echo "Couldn't find ant-launcher.jar" 1>&2 >>>>>>> + exit 1 >>>>>>> + fi >>>>>>> } >>>>>>> "$JAVA" -jar "$(find_jar)" "$@" >>>>>> I disagree. shell scripts need to be tab-based. >>>>> Why? >>>> What there a discussion as to how shell scripts should be formatted? >>>> I've used tabs for years, tons of scripts I have worked in have used >>>> tabs. Is there a well known standard for formatting in shell scripts? >>>> >>>> Changing it to match how it is done in other files is not reason enough. >>> We've never discussed file type specific formatting guidelines, so I guess >>> the assumption has always been that we use consistent formatting everywhere. >>> You having used tabs for years is just as equally not a good reason to use >>> tabs when everything else uses spaces. >> but why change it? that introduces churn just for the sake of it. If >> there is no consensus, then leaving things along seems the better >> approach. > > I changed it because we've always used spaces for indentation everywhere, as > it I see it you are seeking an exception to that for shell scripts and a > consensus has not yet formed around that. > If you're looking for precedent then note that this is the only shell script > which contained tabs for indenting and those tabs were introduced by you less > than 3 months ago.
debian/ofbiz-applications.postinst debian/ofbiz-framework.config debian/ofbiz-framework.postrm debian/ofbiz-framework.ofbiz.init debian/ofbiz-specialpurpose.postinst debian/ofbiz-applications.prerm debian/ofbiz-framework.postinst debian/ofbiz-framework.prerm debian/ofbiz-specialpurpose.prerm The above are shell scripts, added/maintained by me, of course, that all contain tabs. debian/move-files.pl contains tabs. debian/rules does as well, but that is a Makefile, so it kind of has to. debian/ofbiz-framework.logrotate has tabs, but that's the pattern in debian. debian/extract-entity-engine.xslt and debian/override-data.xslt are xml files with a single-space indent.
