[
https://issues.apache.org/jira/browse/OFBIZ-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847675#action_12847675
]
BJ Freeman commented on OFBIZ-3026:
-----------------------------------
you made some changes in record.java
as a result I have
line 554<<<<<<< .mine
//some input lines may be less than the header model.
if (st.hasMoreTokens()) {
try {
strVal = st.nextToken();
if (strVal.equals("" + delimiter)) {
strVal = null;
} else {
if (st.hasMoreTokens()) {
st.nextToken();
=======
line575 >>>>>>> .r923845
}
} catch (NoSuchElementException nsee) {
throw new DataFileException("Field " + modelField.name
+ " could not be read from a line (" + lineNum + ") with only " +
line.length() + " chars.", nsee);
}
}
}
<<<<<<< .mine
else//if input line is less than the header model then pad with
null
{
strVal = null;
}
=======
line 583 <<<<<<< .mine
else//if input line is less than the header model then pad with
null
{
strVal = null;
}
=======
> Datafile does not catch lack of delimiter if at end of line.
> ------------------------------------------------------------
>
> Key: OFBIZ-3026
> URL: https://issues.apache.org/jira/browse/OFBIZ-3026
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 9.04, SVN trunk
> Environment: 9.04 revision 823664
> Reporter: BJ Freeman
> Assignee: Jacques Le Roux
> Fix For: Release Branch 9.04
>
> Attachments: OFBIZ-3026missingdataindatafile.patch,
> OFBIZ-3026recorditerator.patch, RecordIterator.java, screenshot-1.jpg
>
>
> datafile that does not have the last delimiter before the CRLF.
> 2009-10-10 20:33:19,265 (http-0.0.0.0-8443-2)
> [ModelDataFileReader.java:135:INFO ] -- getModelDataFile: #1 Loaded dataFile:
> Product
> 2009-10-10 20:33:19,265 (http-0.0.0.0-8443-2) [ModelDataFileReader.java:74
> :INFO ] [ModelDataFileReader.getModelDataFileReader] : returning reader.
> 2009-10-10 20:33:19,265 (http-0.0.0.0-8443-2) [ModelDataFileReader.java:74
> :INFO ] [ModelDataFileReader.getModelDataFileReader] : returning reader.
> 2009-10-10 20:33:19,265 (http-0.0.0.0-8443-2) [ ?:?
> :INFO ]
> ---- exception report
> ----------------------------------------------------------
> Exception: org.ofbiz.datafile.DataFileException
> Message: Field map could not be read from a line (1) with only 234 chars.
> (null)
> ---- cause
> ---------------------------------------------------------------------
> Exception: java.util.NoSuchElementException
> Message: null
> ---- stack trace
> ---------------------------------------------------------------
> java.util.NoSuchElementException
> java.util.StringTokenizer.nextToken(Unknown Source)
> org.ofbiz.datafile.Record.createDelimitedRecord(Record.java:555)
> org.ofbiz.datafile.RecordIterator.getNextLine(RecordIterator.java:123)
> org.ofbiz.datafile.RecordIterator.setupStream(RecordIterator.java:79)
> org.ofbiz.datafile.RecordIterator.<init>(RecordIterator.java:61)
> org.ofbiz.datafile.DataFile.makeRecordIterator(DataFile.java:165)
> org.ofbiz.datafile.DataFile.readDataFile(DataFile.java:124)
> org.ofbiz.datafile.DataFile.readFile(DataFile.java:63)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
